Bug 149651

Summary: Move WebKit2 AsyncTask to WebCore CrossThreadTask
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, commit-queue
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1
achristensen: review+
Patch v1 achristensen: review+

Brady Eidson
Reported 2015-09-29 16:08:37 PDT
Move WebKit2 AsyncTask to WebCore CrossThreadTask 1 - It'll be needed in WebCore for IndexedDB. 2 - It's really only used for an asynchronous task that enforces cross-thread copying, so that's a better name for it.
Attachments
Patch v1 (65.62 KB, patch)
2015-09-29 16:10 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
Patch v1 (75.02 KB, patch)
2015-09-29 16:16 PDT, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2015-09-29 16:10:18 PDT
Created attachment 262117 [details] Patch v1
Brady Eidson
Comment 2 2015-09-29 16:16:22 PDT
Created attachment 262118 [details] Patch v1
WebKit Commit Bot
Comment 3 2015-09-29 16:18:08 PDT
Attachment 262118 [details] did not pass style-queue: ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:311: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:141: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/CrossThreadTask.h:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/CrossThreadTask.h:51: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 4 2015-09-29 16:29:49 PDT
https://trac.webkit.org/changeset/190331
Brady Eidson
Comment 5 2015-09-29 17:17:01 PDT
Followup in https://trac.webkit.org/changeset/190332
Note You need to log in before you can comment on or make changes to this bug.