Bug 149332

Summary:

Subpixel layout: Do not truncate table padding values during layout.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

buildbot, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

132010

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Patch	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Archive of layout-test-results from ews101 for mac-mavericks	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none

zalan

Reported 2015-09-17 20:52:39 PDT

Change int -> LayoutUnit.

Attachments
Patch (452.18 KB, patch) 2015-09-17 20:59 PDT, zalan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (324.20 KB, application/zip) 2015-09-17 21:27 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (294.13 KB, application/zip) 2015-09-17 21:44 PDT, Build Bot	no flags	Details
Patch (748.01 KB, patch) 2015-09-18 13:34 PDT, zalan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (960.93 KB, application/zip) 2015-09-18 14:11 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-mavericks (828.78 KB, application/zip) 2015-09-18 14:11 PDT, Build Bot	no flags	Details
Patch (1.31 MB, patch) 2015-09-18 14:51 PDT, zalan	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-mavericks (2.20 MB, application/zip) 2015-09-18 15:35 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (2.34 MB, application/zip) 2015-09-18 16:12 PDT, Build Bot	no flags	Details
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2015-09-17 20:59:48 PDT

Created attachment 261478 [details] Patch

Build Bot

Comment 2 2015-09-17 21:27:36 PDT

Comment on attachment 261478 [details] Patch Attachment 261478 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/181852 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2015-09-17 21:27:39 PDT

Created attachment 261482 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-09-17 21:44:45 PDT

Comment on attachment 261478 [details] Patch Attachment 261478 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/181872 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2015-09-17 21:44:47 PDT

Created attachment 261485 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

zalan

Comment 6 2015-09-18 13:34:37 PDT

Created attachment 261518 [details] Patch

Build Bot

Comment 7 2015-09-18 14:10:55 PDT

Comment on attachment 261518 [details] Patch Attachment 261518 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/184177 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2015-09-18 14:11:01 PDT

Created attachment 261521 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 9 2015-09-18 14:11:14 PDT

Comment on attachment 261518 [details] Patch Attachment 261518 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/184182 Number of test failures exceeded the failure limit.

Build Bot

Comment 10 2015-09-18 14:11:17 PDT

Created attachment 261522 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

zalan

Comment 11 2015-09-18 14:51:53 PDT

Created attachment 261528 [details] Patch

Build Bot

Comment 12 2015-09-18 15:35:17 PDT

Comment on attachment 261528 [details] Patch Attachment 261528 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/184408 New failing tests: fast/forms/input-table.html fast/table/spanOverlapRepaint.html tables/mozilla/bugs/bug46368-2.html tables/mozilla/bugs/bug55545.html editing/selection/3690719.html tables/mozilla/bugs/bug7342.html tables/mozilla/bugs/bug1188.html fast/forms/input-value.html fast/text/textIteratorNilRenderer.html fast/sub-pixel/table-cells-with-padding-do-not-wrap.html tables/mozilla_expected_failures/bugs/bug92647-1.html editing/selection/3690703-2.html fast/forms/001.html tables/mozilla/bugs/bug59354.html fast/table/colspanMinWidth.html tables/mozilla/bugs/bug30692.html fast/forms/basic-buttons.html fast/table/colspanMinWidth-vertical.html tables/mozilla/bugs/bug46368-1.html fast/table/003.html tables/mozilla/bugs/bug24200.html fast/forms/input-double-click-selection-gap-bug.html editing/selection/3690703.html fast/sub-pixel/table-rtl-padding.html tables/mozilla/bugs/bug18359.html

Build Bot

Comment 13 2015-09-18 15:35:21 PDT

Created attachment 261530 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 14 2015-09-18 16:11:58 PDT

Comment on attachment 261528 [details] Patch Attachment 261528 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/184487 New failing tests: fast/forms/input-table.html fast/table/spanOverlapRepaint.html fast/text/textIteratorNilRenderer.html tables/mozilla/bugs/bug55545.html editing/selection/3690719.html tables/mozilla/bugs/bug7342.html tables/mozilla/bugs/bug1188.html fast/forms/input-value.html tables/mozilla/bugs/bug46368-2.html fast/sub-pixel/table-cells-with-padding-do-not-wrap.html tables/mozilla_expected_failures/bugs/bug92647-1.html editing/selection/3690703-2.html fast/forms/001.html tables/mozilla/bugs/bug59354.html fast/table/colspanMinWidth.html tables/mozilla/bugs/bug30692.html fast/forms/basic-buttons.html fast/table/colspanMinWidth-vertical.html tables/mozilla/bugs/bug46368-1.html fast/table/003.html tables/mozilla/bugs/bug24200.html fast/forms/input-double-click-selection-gap-bug.html editing/selection/3690703.html fast/sub-pixel/table-rtl-padding.html tables/mozilla/bugs/bug18359.html

Build Bot

Comment 15 2015-09-18 16:12:03 PDT

Created attachment 261540 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

zalan

Comment 16 2015-10-28 10:48:47 PDT

*** This bug has been marked as a duplicate of bug 149366 ***

Note You need to log in before you can comment on or make changes to this bug.