Bug 148942

Summary: [CSS Grid Layout] Using {row, column}-axis terms in alignment related logic
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, glenn, hyatt, jfernandez, kondapallykalyan, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Javier Fernandez
Reported 2015-09-07 13:44:09 PDT
Some of the function defined to implement the alignment logic are not clear enough. In order to improve its coherence, we will use the terms row-axis and column-axis to refer the direction the alignment logic is applied to.
Attachments
Patch (4.66 KB, patch)
2015-09-07 13:52 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (4.66 KB, patch)
2015-09-15 06:40 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (4.66 KB, patch)
2015-09-15 06:51 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2015-09-07 13:52:13 PDT
Created attachment 260747 [details] Patch
Sergio Villar Senin
Comment 2 2015-09-08 07:07:38 PDT
Comment on attachment 260747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260747&action=review > Source/WebCore/ChangeLog:3 > + [CSS Grid Layout] Using [row, column}-axis terms in alignment related logic Either use ] or } but do not mix them
Javier Fernandez
Comment 3 2015-09-15 06:40:13 PDT
Created attachment 261189 [details] Patch
Javier Fernandez
Comment 4 2015-09-15 06:51:14 PDT
Created attachment 261191 [details] Patch
WebKit Commit Bot
Comment 5 2015-09-15 07:48:55 PDT
Comment on attachment 261191 [details] Patch Clearing flags on attachment: 261191 Committed r189806: <http://trac.webkit.org/changeset/189806>
WebKit Commit Bot
Comment 6 2015-09-15 07:49:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.