Bug 148844

Summary: Import a Chromium <input type=color> test
Product: WebKit Reporter: Jon Honeycutt <jhoneycutt>
Component: FormsAssignee: Jon Honeycutt <jhoneycutt>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, dbates, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=119094
Attachments:
Description Flags
Patch aestes: review+

Jon Honeycutt
Reported 2015-09-04 16:23:09 PDT
Import a Chromium <input type=color> test that tests that no crash occurs when changing the color with the picker open.
Attachments
Patch (1.88 KB, patch)
2015-09-04 16:24 PDT, Jon Honeycutt 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jon Honeycutt
Comment 1 2015-09-04 16:24:10 PDT
Created attachment 260644 [details] Patch
Jon Honeycutt
Comment 2 2015-09-04 17:34:13 PDT
Committed r189408: <http://trac.webkit.org/changeset/189408>
Alexey Proskuryakov
Comment 3 2015-09-04 22:32:51 PDT
This test asserts in WebKit1. Will skip for now, but this is really the wrong way to not implement a feature - we should not assert on legitimate code paths. #if ENABLE(INPUT_TYPE_COLOR) std::unique_ptr<ColorChooser> WebChromeClient::createColorChooser(ColorChooserClient* client, const Color& initialColor) { // FIXME: Implement <input type='color'> for WK1 (Bug 119094). ASSERT_NOT_REACHED(); return nullptr; } #endif
Note You need to log in before you can comment on or make changes to this bug.