Bug 148679

Summary: Web Inspector: protocol generator should not allow non-boolean values for "optional" key
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=147664
Bug Depends on:    
Bug Blocks: 147067    
Attachments:
Description Flags
Proposed Fix none

Blaze Burg
Reported 2015-09-01 08:50:00 PDT
Whoops
Attachments
Proposed Fix (5.34 KB, patch)
2015-09-01 11:18 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-01 08:50:49 PDT
<rdar://problem/22518956>
Blaze Burg
Comment 2 2015-09-01 11:18:39 PDT
Created attachment 260375 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2015-09-01 11:20:37 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Joseph Pecoraro
Comment 4 2015-09-01 11:22:42 PDT
Comment on attachment 260375 [details] Proposed Fix r=me
WebKit Commit Bot
Comment 5 2015-09-01 11:45:20 PDT
Comment on attachment 260375 [details] Proposed Fix Clearing flags on attachment: 260375 Committed r189222: <http://trac.webkit.org/changeset/189222>
WebKit Commit Bot
Comment 6 2015-09-01 11:45:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.