Bug 148612

Summary: Web Inspector: tighten up lifetimes for InspectorController-owned objects; add brace initializers to agents
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, mkwst, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 148481    
Attachments:
Description Flags
Proposed Fix
none
Proposed Fix (rebased for EWS) none

Blaze Burg
Reported 2015-08-29 15:41:54 PDT
Morally, they are owned by InspectorController. InstrumentingAgents has to be Ref<> because of sharing with instrumentation cookies for now. While I touch every file, might as well clean up to be consistently using brace initializers in the declaration.
Attachments
Proposed Fix (148.06 KB, patch)
2015-08-29 15:50 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (rebased for EWS) (147.38 KB, patch)
2015-09-01 10:03 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-29 15:42:58 PDT
<rdar://problem/22490698>
Blaze Burg
Comment 2 2015-08-29 15:50:19 PDT
Created attachment 260227 [details] Proposed Fix Depends on other bugs, so it won't apply yet.
Joseph Pecoraro
Comment 3 2015-08-31 11:27:16 PDT
Comment on attachment 260227 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=260227&action=review r=me > Source/JavaScriptCore/inspector/agents/JSGlobalObjectDebuggerAgent.h:58 > + InspectorConsoleAgent* m_consoleAgent { nullptr }; Nit: double space
Blaze Burg
Comment 4 2015-09-01 10:03:31 PDT
Created attachment 260366 [details] Proposed Fix (rebased for EWS)
Blaze Burg
Comment 5 2015-09-01 10:52:41 PDT
Committed r189218: <http://trac.webkit.org/changeset/189218>
Note You need to log in before you can comment on or make changes to this bug.