Bug 14861

Summary:

run-webkit-tests should link to Mac crash logs in results.html

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

ddkilzer, eric, mihaip, ojan

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

All

Bug Depends on:

53718

Bug Blocks:

32091, 33230

Attachments:

Description	Flags
Patch with ChangeLog	none
Link to Mac crash logs from results.html	ddkilzer: review+

Adam Roben (:aroben)

Reported 2007-08-02 01:16:48 PDT

patch coming

Attachments
Patch with ChangeLog (6.06 KB, patch) 2007-08-02 01:28 PDT, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
Link to Mac crash logs from results.html (2.74 KB, patch) 2011-02-04 08:46 PST, Adam Roben (:aroben)	ddkilzer: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2007-08-02 01:28:44 PDT

Created attachment 15803 [details] Patch with ChangeLog

Mark Rowe (bdash)

Comment 2 2007-08-02 01:34:08 PDT

Comment on attachment 15803 [details] Patch with ChangeLog I think it would be preferable to not blow away crash logs permanently. Perhaps they could be renamed in some way such that we don't see them in the future, or we could only look at the newest log? Having the crash logs around long-term can be useful for various purposes.

Eric Seidel (no email)

Comment 3 2009-10-28 09:45:30 PDT

*** Bug 30136 has been marked as a duplicate of this bug. ***

Adam Roben (:aroben)

Comment 4 2011-02-03 14:29:44 PST

Once bug 53718 is fixed, all that needs to be done is to add a case for Mac to the captureSavedCrashLog function.

Eric Seidel (no email)

Comment 5 2011-02-03 17:01:00 PST

Chromium already does something like this for their builds under NRWT (or at least I think they do). Once this is added, the commit-queue will automatically include crash reports when reporting flaky crash tests. :)

Adam Roben (:aroben)

Comment 6 2011-02-04 08:46:23 PST

Created attachment 81224 [details] Link to Mac crash logs from results.html

David Kilzer (:ddkilzer)

Comment 7 2011-02-04 08:51:36 PST

Comment on attachment 81224 [details] Link to Mac crash logs from results.html View in context: https://bugs.webkit.org/attachment.cgi?id=81224&action=review r=me! > Tools/Scripts/old-run-webkit-tests:1763 > + if (my @reportCrashPIDs = sort map { /^\s*(\d+)/; $1 } grep { /ReportCrash/ } `ps x`) { Nit: I prefer to use "/bin/ps" instead of just "ps", but it only matters if more than one 'ps' is installed in the path (e.g., by an attacker or MacPorts).

Adam Roben (:aroben)

Comment 8 2011-02-04 09:31:57 PST

Committed r77633: <http://trac.webkit.org/changeset/77633>

Eric Seidel (no email)

Comment 9 2011-02-04 13:30:29 PST

Comment on attachment 81224 [details] Link to Mac crash logs from results.html View in context: https://bugs.webkit.org/attachment.cgi?id=81224&action=review > Tools/Scripts/old-run-webkit-tests:1759 > + $glob = File::Spec->catfile("~", "Library", "Logs", "CrashReporter", $dumpToolName . "_*.crash"); The location is OS version dependent. So I think we'll need to tweak this for Leopard and Tiger (and possibly Lion).

Adam Roben (:aroben)

Comment 10 2011-02-04 13:42:17 PST

(In reply to comment #9) > (From update of attachment 81224 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81224&action=review > > > Tools/Scripts/old-run-webkit-tests:1759 > > + $glob = File::Spec->catfile("~", "Library", "Logs", "CrashReporter", $dumpToolName . "_*.crash"); > > The location is OS version dependent. So I think we'll need to tweak this for Leopard and Tiger (and possibly Lion). Be my guest! I just did what works on SnowLeopard, as I didn't have Leopard and Tiger available for testing.

Note You need to log in before you can comment on or make changes to this bug.