Bug 148140

Summary:

Replace all uses of std::mutex/std::condition_variable with WTF::Lock/WTF::Condition

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Web Template Framework

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

Other

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

147841, 157924

Attachments:

Description	Flags
work so far	none
it is written	none
the patch	none
the patch	none
the patch	ggaren: review+

Filip Pizlo

Reported 2015-08-18 14:08:27 PDT

WTF's locking primitives are way faster and way smaller. We should use those always.

Attachments
work so far (50.52 KB, patch) 2015-08-18 17:46 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
it is written (116.28 KB, patch) 2015-08-18 18:57 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (118.19 KB, patch) 2015-08-18 20:50 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (118.62 KB, patch) 2015-08-18 21:21 PDT, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (118.64 KB, patch) 2015-08-18 22:01 PDT, Filip Pizlo	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2015-08-18 17:46:01 PDT

Created attachment 259335 [details] work so far

Filip Pizlo

Comment 2 2015-08-18 18:57:00 PDT

Created attachment 259340 [details] it is written

Filip Pizlo

Comment 3 2015-08-18 20:50:32 PDT

Created attachment 259345 [details] the patch

WebKit Commit Bot

Comment 4 2015-08-18 20:53:25 PDT

Attachment 259345 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:81: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 5 2015-08-18 21:21:21 PDT

Created attachment 259349 [details] the patch Fix more builds

WebKit Commit Bot

Comment 6 2015-08-18 21:23:48 PDT

Attachment 259349 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:82: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Filip Pizlo

Comment 7 2015-08-18 22:01:36 PDT

Created attachment 259353 [details] the patch

WebKit Commit Bot

Comment 8 2015-08-18 22:04:32 PDT

Attachment 259353 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:83: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 9 2015-08-19 11:06:57 PDT

Comment on attachment 259353 [details] the patch r=me

Filip Pizlo

Comment 10 2015-08-19 11:18:49 PDT

Landed in http://trac.webkit.org/changeset/188642

Note You need to log in before you can comment on or make changes to this bug.