Bug 147195

Summary: jsc-tailcall: Disable tail calls when profiler is enabled
Product: WebKit Reporter: Basile Clement <basile_clement>
Component: JavaScriptCoreAssignee: Basile Clement <basile_clement>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146484    
Bug Blocks: 146477    
Attachments:
Description Flags
Patch msaboff: review+

Basile Clement
Reported 2015-07-22 11:01:58 PDT
The profiler relies on having pairs of op_profile_will_call / op_profile_did_call opcodes for function calls, which is not possible with tail calls since we never return from the tail call. So, we should temporarily disable tail calls when the profiler is enabled, until we figure out a way of handling them in the profiler.
Attachments
Patch (4.40 KB, patch)
2015-08-04 11:28 PDT, Basile Clement 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basile Clement
Comment 1 2015-08-04 11:28:38 PDT
Created attachment 258188 [details] Patch
Michael Saboff
Comment 2 2015-08-04 11:59:01 PDT
Comment on attachment 258188 [details] Patch r=me
Basile Clement
Comment 3 2015-09-04 13:15:35 PDT
*** This bug has been marked as a duplicate of bug 148661 ***
Note You need to log in before you can comment on or make changes to this bug.