Bug 146628

Summary:	[Win] Fix the broken clean build which makes the EWS unreliable
Product:	WebKit	Reporter:	Csaba Osztrogonác <ossy>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Blocker	CC:	achristensen, ap, bfulgham, clopez, lforschler, ossy, rniwa, webkit-bug-importer
Priority:	P1	Keywords:	InRadar
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Csaba Osztrogonác

Reported 2015-07-06 01:37:27 PDT

Apple Windows EWS rejects all patches with these false positive failure: /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:893: recipe for target 'XMLViewerCSS.h' failed python /home/buildbot/WebKit/WebKitBuild/Release/include/private/JavaScriptCore/jsmin.py </home/buildbot/WebKit/Source/WebCore/inspector/CommandLineAPIModuleSource.js >> ./CommandLineAPIModuleSource.min.js python: can't open file '/home/buildbot/WebKit/WebKitBuild/Release/include/private/JavaScriptCore/jsmin.py': [Errno 2] No such file or directory /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:904: recipe for target 'XMLViewerJS.h' failed make: *** [XMLViewerJS.h] Error 2 python: can't open file '/home/buildbot/WebKit/WebKitBuild/Release/include/private/JavaScriptCore/inline-and-minify-stylesheets-and-scripts.py': [Errno 2] No such file or directory /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:1205: recipe for target 'InspectorOverlayPage.h' failed make: *** [InspectorOverlayPage.h] Error 2 python: can't open file '/home/buildbot/WebKit/WebKitBuild/Release/include/private/JavaScriptCore/jsmin.py': [Errno 2] No such file or directory /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:1212: recipe for target 'CommandLineAPIModuleSource.h' failed make: *** [CommandLineAPIModuleSource.h] Error 2 Failed to build /home/buildbot/WebKit/Source/WebCore/DerivedSources.make: at build-generated-files.pl line 91.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-07-06 01:37:49 PDT

<rdar://problem/21680676>

Csaba Osztrogonác

Comment 2 2015-07-06 02:49:25 PDT

It seems it isn't an EWS issue, but a sesrious incremental build issue. I managed to reproduce it on the Windows buildbots too: (with clean build) - https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/71337 - https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/89353

Csaba Osztrogonác

Comment 3 2015-07-06 22:18:13 PDT

Any plan to fix the Windows build? It isn't good that Windows EWS reports false positive build failures for each patch. :((

Csaba Osztrogonác

Comment 4 2015-07-08 02:58:51 PDT

The clean build is still broken: - https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/71403 - https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/89420 And the Win EWS still reports false positive failures due to this bug.

Alexey Proskuryakov

Comment 5 2015-07-10 04:35:26 PDT

While this obviously needs to be fixed, I'm also puzzled about how this causes false positives on EWS.

Csaba Osztrogonác

Comment 6 2015-07-21 09:16:45 PDT

The clean build is still broken: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/71684 And the EWS still reports false positive failures. :( Are you planning to fix it in the future?

Brent Fulgham

Comment 7 2015-07-21 09:56:24 PDT

(In reply to comment #6) > The clean build is still broken: > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/ > 71684 > > And the EWS still reports false positive failures. :( > > Are you planning to fix it in the future? Yes! We've had trouble investigating this issue due to the whitelisting problem on our EWS bots. I am very hopeful that we will have that resolved today or tomorrow, at which point we can figure out what's going on here. I have attempted to reproduce this build failure locally, and find that if I do a full rebuild, or delete my entire Windows build output directory and build, that I have NO PROBLEMS. It's very frustrating. :-(

Csaba Osztrogonác

Comment 8 2015-07-30 11:58:59 PDT

any update?

Csaba Osztrogonác

Comment 9 2015-08-04 10:21:53 PDT

ping?

Alexey Proskuryakov

Comment 10 2015-08-04 12:20:03 PDT

This is being worked on. Several other problems affecting Windows EWS got fixed in the meanwhile, including a networking setup issue and bug 147636.

Csaba Osztrogonác

Comment 11 2015-09-04 05:29:31 PDT

It is already fixed.

Note You need to log in before you can comment on or make changes to this bug.