Bug 146591

Summary: Use Ref/RefPtr instead of PassRefPtr in WebKit2 - 2
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit2Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-07-03 07:27:51 PDT
SSIA
Attachments
Patch (84.45 KB, patch)
2015-07-03 07:30 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (80.30 KB, patch)
2015-07-03 23:36 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-07-03 07:30:23 PDT
Created attachment 256101 [details] Patch
Gyuyoung Kim
Comment 2 2015-07-03 23:36:06 PDT
Created attachment 256140 [details] Patch
WebKit Commit Bot
Comment 3 2015-07-08 19:32:27 PDT
Comment on attachment 256140 [details] Patch Clearing flags on attachment: 256140 Committed r186566: <http://trac.webkit.org/changeset/186566>
WebKit Commit Bot
Comment 4 2015-07-08 19:32:30 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 5 2015-07-08 21:18:15 PDT
This introduced a build failure in Windows: ..\..\win\Plugins\PluginView.cpp(855): error C2556: 'WTF::PassRefPtr<T> WebCore::PluginView::create(WebCore::Frame *,const WebCore::IntSize &,WebCore::HTMLPlugInElement *,const WebCore::URL &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::String &,bool)' : overloaded function differs only by return type from 'WTF::Ref<WebCore::PluginView> WebCore::PluginView::create(WebCore::Frame *,const WebCore::IntSize &,WebCore::HTMLPlugInElement *,const WebCore::URL &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::String &,bool)' [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj]
Brent Fulgham
Comment 6 2015-07-08 21:38:46 PDT
dbates fixed it: <http://trac.webkit.org/changeset/186578>
Gyuyoung Kim
Comment 7 2015-07-08 22:05:57 PDT
(In reply to comment #6) > dbates fixed it: <http://trac.webkit.org/changeset/186578> Thank you for fixing it.
Note You need to log in before you can comment on or make changes to this bug.