Bug 146001

Summary:

Purge PassRefPtr with Ref or RefPtr in WebKit2

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

144092

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Gyuyoung Kim

Reported 2015-06-15 19:07:00 PDT

As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2. If function can't return nullptr, PassRefPtr is changed with Ref. If not, the function returns RefPtr.

Attachments
Patch (62.30 KB, patch) 2015-06-15 19:08 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (62.37 KB, patch) 2015-06-15 19:15 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (64.16 KB, patch) 2015-06-15 21:56 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (64.92 KB, patch) 2015-06-15 22:01 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (65.71 KB, patch) 2015-06-15 22:10 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (65.80 KB, patch) 2015-06-16 18:56 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2015-06-15 19:08:53 PDT

Created attachment 254920 [details] Patch

Gyuyoung Kim

Comment 2 2015-06-15 19:15:51 PDT

Created attachment 254922 [details] Patch

Gyuyoung Kim

Comment 3 2015-06-15 21:56:16 PDT

Created attachment 254929 [details] Patch

Gyuyoung Kim

Comment 4 2015-06-15 22:01:25 PDT

Created attachment 254930 [details] Patch

Gyuyoung Kim

Comment 5 2015-06-15 22:10:26 PDT

Created attachment 254932 [details] Patch

Darin Adler

Comment 6 2015-06-16 10:55:04 PDT

Comment on attachment 254932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254932&action=review > Source/WebKit2/ChangeLog:8 > + As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2. This wording, which we have used on a lot of patches, is wrong. The patch does not remove these from WebKIt2. It reduces the use of them in WebKit2. > Source/WebKit2/Shared/API/APINumber.h:39 > + static RefPtr<Number> create(NumberType value) Why RefPtr instead of Ref here? > Source/WebKit2/Shared/API/APISecurityOrigin.h:50 > return 0; nullptr > Source/WebKit2/UIProcess/WebPageProxy.cpp:4659 > + callback->performCallbackWithReturnValue(data.size() ? API::SerializedScriptValue::adopt(data).ptr() : 0, hadException); nullptr

Gyuyoung Kim

Comment 7 2015-06-16 18:56:47 PDT

Created attachment 254994 [details] Patch

Gyuyoung Kim

Comment 8 2015-06-16 19:01:30 PDT

Comment on attachment 254932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254932&action=review >> Source/WebKit2/ChangeLog:8 >> + As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2. > > This wording, which we have used on a lot of patches, is wrong. The patch does not remove these from WebKIt2. It reduces the use of them in WebKit2. Yes, you are right. I fix this changelog. Let me write changelog in upcoming patch carefully. >> Source/WebKit2/Shared/API/APINumber.h:39 >> + static RefPtr<Number> create(NumberType value) > > Why RefPtr instead of Ref here? done. >> Source/WebKit2/Shared/API/APISecurityOrigin.h:50 >> return 0; > > nullptr done. >> Source/WebKit2/UIProcess/WebPageProxy.cpp:4659 >> + callback->performCallbackWithReturnValue(data.size() ? API::SerializedScriptValue::adopt(data).ptr() : 0, hadException); > > nullptr done.

WebKit Commit Bot

Comment 9 2015-06-16 20:34:07 PDT

Comment on attachment 254994 [details] Patch Clearing flags on attachment: 254994 Committed r185637: <http://trac.webkit.org/changeset/185637>

WebKit Commit Bot

Comment 10 2015-06-16 20:34:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.