Bug 145756

Summary:

[GTK] Remove the unused scroll function from WebPageGtk.cpp

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, ossy, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Csaba Osztrogonác

Reported 2015-06-08 06:03:19 PDT

Before r164745 the scroll function in WebPageGtk.cpp was same as in WebPage.cpp, except the return type ( void vs bool ): - https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp?rev=164744#L1937 - https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp#L91 But the scroll function in WebPageGtk.cpp is unused as clang noticed it ( https://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp#L2202 ) ../../Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp:91:24: warning: unused function 'scroll' [-Wunused-function] static __inline__ void scroll(Page* page, ScrollDirection direction, ScrollGranularity granularity)

Attachments
Patch (1.56 KB, patch) 2015-06-08 06:04 PDT, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2015-06-08 06:04:08 PDT

WebKit Commit Bot

Comment 2 2015-06-08 07:08:55 PDT

WebKit Commit Bot

Comment 3 2015-06-08 07:08:58 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.