Bug 145318

Summary: [iOS] scrollIntoViewIfNeeded is not working with scroll-snap points
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Layout and RenderingAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, bfulgham, cmarcelo, commit-queue, esprehn+autocc, glenn, jamesr, kondapallykalyan, luiz, simon.fraser, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=145216
Bug Depends on:    
Bug Blocks: 172349    
Attachments:
Description Flags
WIP Patch
none
Patch simon.fraser: review+

Brent Fulgham
Reported 2015-05-22 14:00:14 PDT
In Bug 145216, I corrected a problem where programmatic scrolls did not update the scroll snap state. Unfortunately, I did not recognize that these changes were not sufficient to correct the problem in iOS, because many of the ScrollAnimator methods used on Mac are stubbed out on iOS. This needs to be corrected so that the iOS ScrollAnimator knows about the current scroll snap offset index, so that its default '0' value doesn't keep getting retrieved by WebCore code and resetting the offset. It may be that iOS should keep around a ScrollController object so that we can share the axis offset handling code between the two ports.
Attachments
WIP Patch (51.71 KB, patch)
2015-06-18 18:25 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (52.21 KB, patch)
2015-06-18 22:09 PDT, Brent Fulgham 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-05-22 14:00:55 PDT
This bug manifests as a scroll area (with snap points), where calling 'scrollIntoViewIfNeeded" causes the right scroll snap region to move into view, only to flash back to the zeroth scroll element.
Radar WebKit Bug Importer
Comment 2 2015-05-22 14:01:34 PDT
<rdar://problem/21081501>
Brent Fulgham
Comment 3 2015-06-18 18:25:21 PDT
Created attachment 255161 [details] WIP Patch
Brent Fulgham
Comment 4 2015-06-18 22:09:21 PDT
Created attachment 255172 [details] Patch
Simon Fraser (smfr)
Comment 5 2015-06-19 10:48:38 PDT
Comment on attachment 255172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255172&action=review > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:54 > + HorizontalSnapOffsetIndex, > + VerticalSnapOffsetIndex, Maybe these should have "Current" in the name. > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:115 > + unsigned m_currentHorizontalSnapPointIndex { 0 }; > + unsigned m_currentVerticalSnapPointIndex { 0 }; Do we need to distinguish between "not set" and 0? > Source/WebCore/platform/cocoa/ScrollController.mm:134 > , m_lastMomentumScrollTimestamp(0) > +#if ENABLE(RUBBER_BANDING) > , m_startTime(0) Could use C++11 initialization to avoid these.
Brent Fulgham
Comment 6 2015-06-19 11:04:08 PDT
Comment on attachment 255172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255172&action=review >> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:54 >> + VerticalSnapOffsetIndex, > > Maybe these should have "Current" in the name. I like that better. I'll change to that. >> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:115 >> + unsigned m_currentVerticalSnapPointIndex { 0 }; > > Do we need to distinguish between "not set" and 0? No. "non set" is indicated by empty snap offset vectors. >> Source/WebCore/platform/cocoa/ScrollController.mm:134 >> , m_startTime(0) > > Could use C++11 initialization to avoid these. Good idea.
Brent Fulgham
Comment 7 2015-06-19 12:25:39 PDT
Committed r185762: <http://trac.webkit.org/changeset/185762>
Note You need to log in before you can comment on or make changes to this bug.