Bug 144753

Summary:

exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

basile_clement, commit-queue, fpizlo, ggaren, mark.lam, mmirman, msaboff, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

144178

Attachments:

Description	Flags
patch	none

Saam Barati

Reported 2015-05-07 12:25:39 PDT

This allows the byte code generator to emit byte code that "may" throw exceptions as part of the setup code without worrying that this code will increment the exceptionFuzz counter. We don't want setup code to increment the exceptionFuzz counter because if the limit is reached in setup code there will obviously not be an exception handler to catch the exception and we end up not testing anything of significance.

Attachments
patch (6.17 KB, patch) 2015-05-07 16:29 PDT, Saam Barati	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2015-05-07 16:29:33 PDT

Created attachment 252646 [details] patch

Mark Lam

Comment 2 2015-05-07 16:31:40 PDT

Comment on attachment 252646 [details] patch r=me

WebKit Commit Bot

Comment 3 2015-05-07 17:22:21 PDT

Comment on attachment 252646 [details] patch Clearing flags on attachment: 252646 Committed r183962: <http://trac.webkit.org/changeset/183962>

WebKit Commit Bot

Comment 4 2015-05-07 17:22:26 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.