Bug 143766

Summary: [W32][ANGLE] Warnings during the build
Product: WebKit Reporter: LRN <lrn1986>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: achristensen, bfulgham, cgarcia, lrn1986
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 133028    
Attachments:
Description Flags
Silence two warnings in ANGLE achristensen: review-

LRN
Reported 2015-04-15 06:29:17 PDT
../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/ParseContext.cpp:538:123: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (op == EOpConstructStruct && !type->isArray() && int(type->getStruct()->fields().size()) != function.getParamCount()) { ^ ../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7:0: warning: ignoring #pragma warning [-Wunknown-pragmas] #pragma warning(disable: 4718) ^
Attachments
Silence two warnings in ANGLE (3.96 KB, patch)
2015-04-15 10:05 PDT, LRN 		achristensen: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
LRN
Comment 1 2015-04-15 10:05:14 PDT
Created attachment 250812 [details] Silence two warnings in ANGLE ../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/ParseContext.cpp:538:123: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (op == EOpConstructStruct && !type->isArray() && int(type->getStruct()->fields().size()) != function.getParamCount()) { ^ ../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp:7:0: warning: ignoring #pragma warning [-Wunknown-pragmas] #pragma warning(disable: 4718) ^
Alex Christensen
Comment 2 2016-07-07 12:17:40 PDT
Comment on attachment 250812 [details] Silence two warnings in ANGLE This patch no longer applies to ParseContext.cpp. If the DependencyGraph.cpp change is still needed, please upload an updated patch.
Note You need to log in before you can comment on or make changes to this bug.