Bug 143496

Summary: Constant folding of typed array properties should be handled by AI rather than strength reduction
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, bfulgham, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 143232    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-04-07 13:47:00 PDT
Patch forthcoming.
Attachments
the patch (24.66 KB, patch)
2015-04-07 13:51 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-04-07 13:51:45 PDT
Created attachment 250295 [details] the patch
WebKit Commit Bot
Comment 2 2015-04-07 13:55:04 PDT
Attachment 250295 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGGraph.h:696: The parameter name "arrayMode" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-04-07 13:58:12 PDT
Comment on attachment 250295 [details] the patch r=me
Filip Pizlo
Comment 4 2015-04-07 15:10:39 PDT
Landed in http://trac.webkit.org/changeset/182498
Brent Fulgham
Comment 5 2015-04-08 17:37:56 PDT
This change might have broken Web Inspector on Windows. See <https://bugs.webkit.org/show_bug.cgi?id=143542>.
Note You need to log in before you can comment on or make changes to this bug.