Bug 142574

Summary:

UnlinkedFunctionExecutable should store SourceCode instead of offsets

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

JavaScriptCore

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

barraclough, benjamin, buildbot, fpizlo, ggaren, kling, mark.lam, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

142388

Attachments:

Description	Flags
Cleanup	none
Archive of layout-test-results from ews100 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none

Ryosuke Niwa

Reported 2015-03-11 02:23:28 PDT

UnlinkedFunctionExecutable stores various offsets relative to its owner executable. Just store SourceCode instead. For one extra pointer, we get a lot more clarity. If the size is a concern, we can bit-pack two enums better.

Attachments
Cleanup (13.40 KB, patch) 2015-03-11 02:34 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-mavericks (645.62 KB, application/zip) 2015-03-11 03:31 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (660.80 KB, application/zip) 2015-03-11 03:36 PDT, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2015-03-11 02:34:29 PDT

Created attachment 248408 [details] Cleanup

Build Bot

Comment 2 2015-03-11 03:31:01 PDT

Comment on attachment 248408 [details] Cleanup Attachment 248408 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6620840053440512 New failing tests: fast/profiler/dead-time.html fast/events/window-onerror-exception-in-attr.html fast/frames/sandboxed-iframe-forms.html

Build Bot

Comment 3 2015-03-11 03:31:05 PDT

Created attachment 248409 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-03-11 03:36:38 PDT

Comment on attachment 248408 [details] Cleanup Attachment 248408 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4582258522456064 New failing tests: fast/profiler/dead-time.html fast/events/window-onerror-exception-in-attr.html js/dom/line-column-numbers.html fast/frames/sandboxed-iframe-forms.html

Build Bot

Comment 5 2015-03-11 03:36:41 PDT

Created attachment 248410 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Ryosuke Niwa

Comment 6 2015-03-11 19:12:56 PDT

This won't work because parsing from global code via cache would require us to adjust the source provider as well as line number and columns to be adjusted each time we link.

Note You need to log in before you can comment on or make changes to this bug.