Bug 14256

Summary: Inspecting an element in an Image Document causes an assertion failure (hit while inspecting Acid3)
Product: WebKit Reporter: Sam Weinig <sam>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, aroben, dev+webkit, eric, mitz, mrowe, timothy
Priority: P2 Keywords: InRadar
Version: 523.x (Safari 3)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 16755    
Attachments:
Description Flags
stack trace
none
stack trace none

Sam Weinig
Reported 2007-06-20 20:45:32 PDT
To reproduce, right click an image and choose "Open image in New Window". In the new window, activate the inspector and click the image left pane. Await crash. Crash log forthcoming.
Attachments
stack trace (34.02 KB, text/plain)
2007-06-20 20:50 PDT, Sam Weinig 		no flags
Details
stack trace (34.02 KB, text/plain)
2007-06-20 20:50 PDT, Sam Weinig 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2007-06-20 20:50:08 PDT
Created attachment 15152 [details] stack trace
Sam Weinig
Comment 2 2007-06-20 20:50:19 PDT
Created attachment 15153 [details] stack trace
Sam Weinig
Comment 3 2007-06-20 20:57:32 PDT
This also happens with plugin documents, such as flash.
mitz
Comment 4 2007-12-30 11:27:59 PST
*** Bug 16632 has been marked as a duplicate of this bug. ***
mitz
Comment 5 2008-01-08 09:12:13 PST
The assertion failure results from calling FrameLoader::write(String) for a raw-data based document (an image) but ultimately to fix it one needs to know the expected behavior, i.e. what should the Inspector show in "source" view for non-text documents?
Adam Roben (:aroben)
Comment 6 2008-01-29 10:53:53 PST
<rdar://problem/5712779>
Matt Lilek
Comment 7 2008-02-29 09:52:20 PST
I hit this just loading LexisNexis Academic search results.
Darin Adler
Comment 8 2008-03-26 22:32:57 PDT
Since people are seeing this when inspecting Acid3 we might want to fix it sooner rather than later.
Matt Lilek
Comment 9 2008-03-26 22:37:09 PDT
(In reply to comment #8) > Since people are seeing this when inspecting Acid3 we might want to fix it > sooner rather than later. > I don't actually see a crash in a release build, just a blank panel where the view source should be. Actual assertion failure for bugzilla search posterity: SHOULD NEVER BE REACHED (/Users/matt/Code/WebKit/WebCore/loader/ImageDocument.cpp:91 virtual bool WebCore::ImageTokenizer::write(const WebCore::SegmentedString&, bool))
Adam Roben (:aroben)
Comment 10 2008-11-14 07:42:15 PST
Seems to be fixed now.
Note You need to log in before you can comment on or make changes to this bug.