Bug 142338

Summary: [cmake] Handle unused parameter warnings as build errors except in WebKit2
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 142497    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2015-03-05 06:10:11 PST
To match the actual Mac settings, we should handle unused parameter warnings as build build errors, except in WebKit2. In WebKit2, we should simply suppress them, because Mac port does the same, there is no reason to newly introduced unused parameter warnings in WebKit2 again and again.
Attachments
Patch (2.47 KB, patch)
2015-03-05 06:13 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (2.42 KB, patch)
2015-03-09 12:10 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-03-05 06:13:23 PST
Created attachment 247948 [details] Patch
Csaba Osztrogonác
Comment 2 2015-03-05 06:23:19 PST
webkit-dev thread: https://lists.webkit.org/pipermail/webkit-dev/2015-March/027269.html
Csaba Osztrogonác
Comment 3 2015-03-05 06:28:38 PST
(In reply to comment #0) > To match the actual Mac settings, we should handle unused parameter warnings > as build build errors, except in WebKit2. In WebKit2, we should simply > suppress them, because Mac port does the same, there is no reason to > newly introduced unused parameter warnings in WebKit2 again and again. typo: ... no reason to _fix_ newly ...
Gyuyoung Kim
Comment 4 2015-03-05 17:46:17 PST
Comment on attachment 247948 [details] Patch Nobody replied this mail thread. So let's omit to make sound of unused param warning in WebKit2 as Mac port.
Csaba Osztrogonác
Comment 5 2015-03-09 12:10:48 PDT
Created attachment 248267 [details] Patch patch for landing, last EWS check to make sure we won't break the build.
WebKit Commit Bot
Comment 6 2015-03-10 01:33:59 PDT
Comment on attachment 248267 [details] Patch Clearing flags on attachment: 248267 Committed r181318: <http://trac.webkit.org/changeset/181318>
WebKit Commit Bot
Comment 7 2015-03-10 01:34:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.