Bug 142086

Summary:

[REGRESSION] word-spacing property is incorrectly applied

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Layout and Rendering

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cgarcia, commit-queue, Hironori.Fujii, rniwa, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=165796

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch	none
Patch	none

Myles C. Maxfield

Reported 2015-02-27 09:40:15 PST

fast/css/word-spacing-between-blocks.html is failing. It seems to never have passed???

Attachments
Patch (4.99 KB, patch) 2017-09-27 02:33 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.19 MB, application/zip) 2017-09-27 03:43 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.35 MB, application/zip) 2017-09-27 03:48 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.99 MB, application/zip) 2017-09-27 04:09 PDT, Build Bot	no flags	Details
Patch (231.37 KB, patch) 2017-09-27 21:19 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (232.30 KB, patch) 2017-09-27 22:22 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-02-27 09:41:01 PST

<rdar://problem/19985240>

Myles C. Maxfield

Comment 2 2015-02-27 09:50:48 PST

fast/css/word-spacing-between-inlines.html too.

Myles C. Maxfield

Comment 3 2015-02-27 09:52:59 PST

fast/css/word-spacing-characters.html too.

Fujii Hironori

Comment 4 2017-09-26 20:25:51 PDT

> webkit.org/b/142086 fast/text/word-space-between-inlines.html [ ImageOnlyFailure ] This failure is also tracked by this bug.

Fujii Hironori

Comment 5 2017-09-27 02:33:35 PDT

Created attachment 321947 [details] Patch

Build Bot

Comment 6 2017-09-27 03:43:57 PDT

Comment on attachment 321947 [details] Patch Attachment 321947 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4674884 New failing tests: fast/css/word-space-extra.html

Build Bot

Comment 7 2017-09-27 03:43:58 PDT

Created attachment 321951 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-09-27 03:48:05 PDT

Comment on attachment 321947 [details] Patch Attachment 321947 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4674885 New failing tests: fast/css/word-space-extra.html

Build Bot

Comment 9 2017-09-27 03:48:07 PDT

Created attachment 321952 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 10 2017-09-27 04:09:43 PDT

Comment on attachment 321947 [details] Patch Attachment 321947 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4674889 New failing tests: fast/css/word-space-extra.html

Build Bot

Comment 11 2017-09-27 04:09:45 PDT

Created attachment 321953 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Fujii Hironori

Comment 12 2017-09-27 21:15:10 PDT

This EWS failures consists of two problems, a RenderTree mismatch and a pixel test mismatch. The RenderTree mismatch is caused by my change. It looks no problem, needs rebaselined. The pixel test mismatch is not caused by my change. It's a outdated expected.png. Nobody has noticed the outdated expected.png because Pixel tests are executed only when the RenderTree mismatch happened. It needs rebaselined.

Fujii Hironori

Comment 13 2017-09-27 21:19:09 PDT

Created attachment 322063 [details] Patch

Fujii Hironori

Comment 14 2017-09-27 22:22:06 PDT

Created attachment 322068 [details] Patch

WebKit Commit Bot

Comment 15 2017-09-27 23:57:13 PDT

Comment on attachment 322068 [details] Patch Clearing flags on attachment: 322068 Committed r222605: <http://trac.webkit.org/changeset/222605>

WebKit Commit Bot

Comment 16 2017-09-27 23:57:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.