Bug 141938

Summary: Disable font loading events until our implementation gets updated to match the latest spec
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: CSSAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: betravis, buildbot, cdumez, commit-queue, kling, koivisto, mmaxfield, rniwa, simon.fraser
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 141937    
Attachments:
Description Flags
Disabled the feature on Mac
none
Patch for landing
none
Archive of layout-test-results from ews105 for mac-mavericks-wk2
none
Patch for landing none

Ryosuke Niwa
Reported 2015-02-23 17:13:44 PST
It looks like our implementation is obsolete. Temporarily disable it on Mac until we catch up to the latest spec.
Attachments
Disabled the feature on Mac (7.17 KB, patch)
2015-02-23 17:35 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.20 KB, patch)
2015-02-23 18:41 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (699.88 KB, application/zip)
2015-02-23 19:48 PST, Build Bot 		no flags
Details
Patch for landing (7.90 KB, patch)
2015-02-23 20:10 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Bear Travis
Comment 1 2015-02-23 17:22:47 PST
I was doing some update work on the API tracked through bug 135390, but have had to take a break. I think mmaxfield might have been interested in picking this up, but am not sure. I don't mind having the feature turned off until someone can focus on it.
Ryosuke Niwa
Comment 2 2015-02-23 17:33:00 PST
(In reply to comment #1) > I was doing some update work on the API tracked through bug 135390, but have > had to take a break. I think mmaxfield might have been interested in picking > this up, but am not sure. > > I don't mind having the feature turned off until someone can focus on it. Thanks for the clarification! I'm just paranoid that we may end up encouraging authors to use the outdated API if we keep exposing it in the nightly or some port accidentally ship the outdated API.
Ryosuke Niwa
Comment 3 2015-02-23 17:35:51 PST
Created attachment 247173 [details] Disabled the feature on Mac
Myles C. Maxfield
Comment 4 2015-02-23 17:42:06 PST
Yep, I'd love to work on this... alas there is so much to do elsewhere....
Ryosuke Niwa
Comment 5 2015-02-23 18:41:56 PST
Created attachment 247182 [details] Patch for landing
WebKit Commit Bot
Comment 6 2015-02-23 19:37:26 PST
The commit-queue encountered the following flaky tests while processing attachment 247182 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2015-02-23 19:37:56 PST
The commit-queue encountered the following flaky tests while processing attachment 247182 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
Build Bot
Comment 8 2015-02-23 19:48:39 PST
Comment on attachment 247182 [details] Patch for landing Attachment 247182 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5578344384954368 New failing tests: fast/css/fontloader-svg-select.svg
Build Bot
Comment 9 2015-02-23 19:48:44 PST
Created attachment 247191 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Ryosuke Niwa
Comment 10 2015-02-23 20:10:14 PST
Created attachment 247193 [details] Patch for landing
WebKit Commit Bot
Comment 11 2015-02-23 21:01:32 PST
Comment on attachment 247193 [details] Patch for landing Clearing flags on attachment: 247193 Committed r180549: <http://trac.webkit.org/changeset/180549>
WebKit Commit Bot
Comment 12 2015-02-23 21:01:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.