Bug 141451

Summary:

Web Inspector: Crash inspecting styles of element with mutated stylesheet

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, qianlangchen, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=141601

Attachments:

Description	Flags
[PATCH] Proposed Fix	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2015-02-10 17:26:28 PST

* SUMMARY Crash inspecting styles of element with mutated stylesheet. * REDUCTION <style>.foo, .bar { color: red }</style> <div class="bar">Inspect Me</div> <script>document.styleSheets[0].insertRule("body { padding: 10px; }", 0);</script> * STEPS TO REPRODUCE 1. Inspect .bar in test case => CRASH

Attachments
[PATCH] Proposed Fix (9.41 KB, patch) 2015-02-10 17:32 PST, Joseph Pecoraro	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (583.24 KB, application/zip) 2015-02-10 17:54 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (668.97 KB, application/zip) 2015-02-10 18:09 PST, Build Bot	no flags	Details
[PATCH] Proposed Fix (9.41 KB, patch) 2015-02-10 18:34 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2015-02-10 17:26:41 PST

<rdar://problem/19783568>

Joseph Pecoraro

Comment 2 2015-02-10 17:32:43 PST

Created attachment 246353 [details] [PATCH] Proposed Fix

Build Bot

Comment 3 2015-02-10 17:54:00 PST

Comment on attachment 246353 [details] [PATCH] Proposed Fix Attachment 246353 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5035795962396672 New failing tests: inspector/css/stylesheet-with-mutations.html

Build Bot

Comment 4 2015-02-10 17:54:03 PST

Created attachment 246361 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-02-10 18:09:00 PST

Comment on attachment 246353 [details] [PATCH] Proposed Fix Attachment 246353 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5484304364732416 New failing tests: inspector/css/stylesheet-with-mutations.html

Build Bot

Comment 6 2015-02-10 18:09:04 PST

Created attachment 246362 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Joseph Pecoraro

Comment 7 2015-02-10 18:32:20 PST

Oh oops. Will update patch with new strings.

Joseph Pecoraro

Comment 8 2015-02-10 18:34:47 PST

Created attachment 246364 [details] [PATCH] Proposed Fix

Timothy Hatcher

Comment 9 2015-02-12 10:15:32 PST

Comment on attachment 246364 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=246364&action=review > Source/WebCore/css/CSSStyleSheet.h:91 > + bool hadRulesMutation() const { return m_mutatedRules; } hasRulesMutation? > Source/WebCore/css/CSSStyleSheet.h:92 > + void clearHadRulesMutation() { m_mutatedRules = false; } s/had/has/

Chris Dumez

Comment 10 2015-02-12 10:19:46 PST

Comment on attachment 246364 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=246364&action=review > Source/WebCore/inspector/InspectorStyleSheet.cpp:865 > for (size_t i = 0, size = ranges.size(); i < size; ++i) { nit: We could use a nice C++11 range loop here.

Joseph Pecoraro

Comment 11 2015-02-12 12:03:52 PST

(In reply to comment #9) > Comment on attachment 246364 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246364&action=review > > > Source/WebCore/css/CSSStyleSheet.h:91 > > + bool hadRulesMutation() const { return m_mutatedRules; } > > hasRulesMutation? > > > Source/WebCore/css/CSSStyleSheet.h:92 > > + void clearHadRulesMutation() { m_mutatedRules = false; } > > s/had/has/ I like "had" here. At some point, the rules mutated, they might have reverted back to the original, but all this tracks is that there was some mutation in the past.

WebKit Commit Bot

Comment 12 2015-02-12 12:47:17 PST

Comment on attachment 246364 [details] [PATCH] Proposed Fix Clearing flags on attachment: 246364 Committed r180005: <http://trac.webkit.org/changeset/180005>

WebKit Commit Bot

Comment 13 2015-02-12 12:47:24 PST

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 14 2015-02-13 22:03:36 PST

The new test doesn't work well on some bots, filed bug 141601.

Note You need to log in before you can comment on or make changes to this bug.