Bug 140882

Summary: [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, commit-queue, gustavo, mcatanzaro, mrobinson, svillar, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98932    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Updated patch gustavo: review+

Carlos Garcia Campos
Reported 2015-01-26 02:19:44 PST
Similar to the local-storage-directory, it should be set on construction.
Attachments
Patch (7.67 KB, patch)
2015-01-26 02:23 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (7.48 KB, patch)
2015-05-25 02:39 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-01-26 02:23:37 PST
Created attachment 245335 [details] Patch We need to enable IndexedDB again first, see bug #98932
WebKit Commit Bot
Comment 2 2015-01-26 02:24:49 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gustavo Noronha (kov)
Comment 3 2015-01-28 03:23:19 PST
Comment on attachment 245335 [details] Patch I feel like we should drop the -database part from the name since 'db' already means that and it is not easy to confuse this with something that is not a database. Otherwise looks good.
Carlos Garcia Campos
Comment 4 2015-01-28 03:27:53 PST
(In reply to comment #3) > Comment on attachment 245335 [details] > Patch > > I feel like we should drop the -database part from the name since 'db' > already means that and it is not easy to confuse this with something that is > not a database. Otherwise looks good. Yes, I thought about that, and added the -directory because db is part of the IndexedDB, but what other thing could be the directory for? I'll update the patch, thanks for the review!
Carlos Garcia Campos
Comment 5 2015-05-25 02:39:49 PDT
Created attachment 253677 [details] Updated patch
Gustavo Noronha (kov)
Comment 6 2015-05-25 04:29:44 PDT
Comment on attachment 253677 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=253677&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:345 > + * WebKitWebContext:indexed-db-database-directory: Still has the -database bit.
Carlos Garcia Campos
Comment 7 2015-05-25 04:30:36 PDT
(In reply to comment #6) > Comment on attachment 253677 [details] > Updated patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253677&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:345 > > + * WebKitWebContext:indexed-db-database-directory: > > Still has the -database bit. Oops, good catch!
Carlos Garcia Campos
Comment 8 2015-05-25 08:16:02 PDT
Committed r184851: <http://trac.webkit.org/changeset/184851>
Note You need to log in before you can comment on or make changes to this bug.