Bug 140851

Summary:

fast/html/marquee-scrollamount.html is flaky

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, buildbot, commit-queue, ddkilzer, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=50434

Bug Depends on:

140863

Bug Blocks:

Attachments:

Description	Flags
proposed fix	ddkilzer: review+, ddkilzer: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
proposed fix	none

Alexey Proskuryakov

Reported 2015-01-23 22:12:10 PST

fast/html/marquee-scrollamount.html frequently fails on Yosemite Debug WK2. Looking at the test, it is inherently flaky. Some non-trivial time can pass before the zero delay timer fires, and nothing prevents the marquee from updating its position.

Attachments
proposed fix (1.53 KB, patch) 2015-01-23 22:14 PST, Alexey Proskuryakov	ddkilzer: review+ ddkilzer: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (558.82 KB, application/zip) 2015-01-23 23:01 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (680.89 KB, application/zip) 2015-01-23 23:07 PST, Build Bot	no flags	Details
proposed fix (6.11 KB, patch) 2015-01-25 10:00 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2015-01-23 22:14:39 PST

Created attachment 245277 [details] proposed fix

Build Bot

Comment 2 2015-01-23 23:01:04 PST

Comment on attachment 245277 [details] proposed fix Attachment 245277 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6471229061988352 New failing tests: fast/html/marquee-scrollamount.html

Build Bot

Comment 3 2015-01-23 23:01:07 PST

Created attachment 245279 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

David Kilzer (:ddkilzer)

Comment 4 2015-01-23 23:04:17 PST

Comment on attachment 245277 [details] proposed fix r=me

David Kilzer (:ddkilzer)

Comment 5 2015-01-23 23:06:31 PST

(In reply to comment #4) > Comment on attachment 245277 [details] > proposed fix > > r=me Except it looks like it needs some test results cleanup.

Build Bot

Comment 6 2015-01-23 23:07:08 PST

Comment on attachment 245277 [details] proposed fix Attachment 245277 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5230963839729664 New failing tests: fast/html/marquee-scrollamount.html

Build Bot

Comment 7 2015-01-23 23:07:11 PST

Created attachment 245280 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

WebKit Commit Bot

Comment 8 2015-01-23 23:58:31 PST

The commit-queue encountered the following flaky tests while processing attachment 245277 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 9 2015-01-23 23:58:57 PST

The commit-queue encountered the following flaky tests while processing attachment 245277 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.

Alexey Proskuryakov

Comment 10 2015-01-25 00:50:54 PST

I can fix the test more reliably, but this depends on fixing an actual bug in HTMLMarqueeElement.

Alexey Proskuryakov

Comment 11 2015-01-25 10:00:21 PST

Created attachment 245309 [details] proposed fix Not marking for review yet, because this depends on another patch, and EWS wouldn't be testing the right thing.

WebKit Commit Bot

Comment 12 2015-01-25 21:01:26 PST

Comment on attachment 245309 [details] proposed fix Clearing flags on attachment: 245309 Committed r179103: <http://trac.webkit.org/changeset/179103>

WebKit Commit Bot

Comment 13 2015-01-25 21:01:32 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.