Bug 140840

Summary: Implement system fonts FontDescription caching at RenderTheme level
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140577    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2015-01-23 15:06:19 PST
Implement system fonts FontDescription caching at RenderTheme level instead of duplicating the logic in its subclasses for each platform. This reduces duplication and reduces the amount of platform-specific code. This will also make the refactoring at Bug 140577 a lot easier.
Attachments
Patch (34.68 KB, patch)
2015-01-23 15:25 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (34.68 KB, patch)
2015-01-23 15:40 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (34.68 KB, patch)
2015-01-23 16:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-23 15:25:05 PST
Created attachment 245253 [details] Patch
Chris Dumez
Comment 2 2015-01-23 15:40:09 PST
Created attachment 245255 [details] Patch
Andreas Kling
Comment 3 2015-01-23 16:34:16 PST
Comment on attachment 245255 [details] Patch r=me
Chris Dumez
Comment 4 2015-01-23 16:54:39 PST
Created attachment 245261 [details] Patch
WebKit Commit Bot
Comment 5 2015-01-23 17:41:35 PST
Comment on attachment 245261 [details] Patch Clearing flags on attachment: 245261 Committed r179050: <http://trac.webkit.org/changeset/179050>
WebKit Commit Bot
Comment 6 2015-01-23 17:41:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.