Bug 140761

Summary: PropertyListNode::emitNode duplicates the code to put a constant property
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140491    
Attachments:
Description Flags
Fixes the bug
none
Added back the missing continue none

Ryosuke Niwa
Reported 2015-01-21 23:05:05 PST
PropertyListNode::emitNode shouldn't duplicate the code to put a constant property.
Attachments
Fixes the bug (4.31 KB, patch)
2015-01-21 23:08 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added back the missing continue (4.29 KB, patch)
2015-01-21 23:26 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-01-21 23:08:27 PST
Created attachment 245123 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2015-01-21 23:26:19 PST
Created attachment 245124 [details] Added back the missing continue
Geoffrey Garen
Comment 3 2015-01-22 08:49:52 PST
Comment on attachment 245124 [details] Added back the missing continue r=me
Ryosuke Niwa
Comment 4 2015-01-22 10:02:44 PST
Comment on attachment 245124 [details] Added back the missing continue Thanks for the review!
WebKit Commit Bot
Comment 5 2015-01-22 10:07:15 PST
Comment on attachment 245124 [details] Added back the missing continue Clearing flags on attachment: 245124 Committed r178918: <http://trac.webkit.org/changeset/178918>
WebKit Commit Bot
Comment 6 2015-01-22 10:07:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.