Bug 140754

Summary: Consolidate out arguments of parseFunctionInfo into a struct
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: JavaScriptCoreAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, fpizlo, ggaren, mark.lam, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140491    
Attachments:
Description Flags
Refactoring none

Ryosuke Niwa
Reported 2015-01-21 19:54:04 PST
parseFunctionInfo has a whole bunch of out arguments. We should put them all into a struct for better code readability.
Attachments
Refactoring (31.32 KB, patch)
2015-01-21 20:15 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-01-21 20:15:09 PST
Created attachment 245111 [details] Refactoring
Ryosuke Niwa
Comment 2 2015-01-21 20:55:19 PST
I don't think EWS failures are related to this patch.
Ryosuke Niwa
Comment 3 2015-01-21 21:56:33 PST
Thanks for the review!
WebKit Commit Bot
Comment 4 2015-01-21 22:39:28 PST
Comment on attachment 245111 [details] Refactoring Clearing flags on attachment: 245111 Committed r178888: <http://trac.webkit.org/changeset/178888>
WebKit Commit Bot
Comment 5 2015-01-21 22:39:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.