Bug 138646

Summary:

Move WebCore/loader to std::unique_ptr

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebCore Misc.

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, japhet, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

128007

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	none
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Patch for mac ews	none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Patch for landing	none

Gyuyoung Kim

Reported 2014-11-11 18:01:12 PST

Clean up OwnPtr in WebCore/loader.

Attachments
Patch (21.49 KB, patch) 2014-11-11 18:02 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (20.80 KB, patch) 2014-11-11 23:06 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (20.76 KB, patch) 2014-11-12 16:56 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for landing (20.86 KB, patch) 2014-11-12 18:03 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion (493.70 KB, application/zip) 2014-11-13 17:52 PST, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (606.39 KB, application/zip) 2014-11-13 19:24 PST, Build Bot	no flags	Details
Patch for mac ews (20.86 KB, patch) 2014-11-13 20:07 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (1.03 MB, application/zip) 2014-11-13 21:18 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (664.10 KB, application/zip) 2014-11-13 21:37 PST, Build Bot	no flags	Details
Patch for landing (17.11 KB, patch) 2014-11-16 21:15 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2014-11-11 18:02:24 PST

Created attachment 241403 [details] Patch

Alexey Proskuryakov

Comment 2 2014-11-11 19:11:39 PST

*** Bug 138645 has been marked as a duplicate of this bug. ***

Gyuyoung Kim

Comment 3 2014-11-11 23:06:01 PST

Created attachment 241414 [details] Patch

Gyuyoung Kim

Comment 4 2014-11-12 16:56:33 PST

Created attachment 241453 [details] Patch

Chris Dumez

Comment 5 2014-11-12 17:26:44 PST

Comment on attachment 241453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241453&action=review r=me with nits. > Source/WebCore/ChangeLog:12 > + No new tests, no behaviro changes. "behavior" > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1362 > + std::unique_ptr<ApplicationCacheGroup> groupCopy(std::make_unique<ApplicationCacheGroup>(cache->group()->manifestURL(), true)); Don't we usually use "auto groupCopy = make_unique<>(...);" in such cases?

Gyuyoung Kim

Comment 6 2014-11-12 18:03:23 PST

Created attachment 241459 [details] Patch for landing

Gyuyoung Kim

Comment 7 2014-11-12 18:04:25 PST

(In reply to comment #5) > Comment on attachment 241453 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241453&action=review > > r=me with nits. > > > Source/WebCore/ChangeLog:12 > > + No new tests, no behaviro changes. > > "behavior" Oops, fixed. > > Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1362 > > + std::unique_ptr<ApplicationCacheGroup> groupCopy(std::make_unique<ApplicationCacheGroup>(cache->group()->manifestURL(), true)); > > Don't we usually use "auto groupCopy = make_unique<>(...);" in such cases? Why not ? It looks like this style is more clear. Fixed.

WebKit Commit Bot

Comment 8 2014-11-13 17:52:07 PST

Comment on attachment 241459 [details] Patch for landing Rejecting attachment 241459 [details] from commit-queue. Number of test failures exceeded the failure limit. Full output: http://webkit-queues.appspot.com/results/6591204879761408

WebKit Commit Bot

Comment 9 2014-11-13 17:52:11 PST

Created attachment 241523 [details] Archive of layout-test-results from webkit-cq-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 10 2014-11-13 19:24:00 PST

Comment on attachment 241459 [details] Patch for landing Attachment 241459 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5228930374041600 Number of test failures exceeded the failure limit.

Build Bot

Comment 11 2014-11-13 19:24:04 PST

Created attachment 241528 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Gyuyoung Kim

Comment 12 2014-11-13 20:07:00 PST

Created attachment 241538 [details] Patch for mac ews

Build Bot

Comment 13 2014-11-13 21:18:11 PST

Comment on attachment 241538 [details] Patch for mac ews Attachment 241538 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6120512971341824 New failing tests: http/tests/appcache/document-write-html-element.html http/tests/security/beforeload-iframe-client-redirect.html http/tests/appcache/cyrillic-uri.html http/tests/appcache/online-whitelist.html http/tests/cache/cache-redirections.html http/tests/appcache/history-test.html http/tests/appcache/crash-when-navigating-away-then-back.html http/tests/appcache/navigating-away-while-cache-attempt-in-progress.html http/tests/appcache/max-size.html http/tests/appcache/origin-quota.html http/tests/appcache/top-frame-1.html http/tests/appcache/whitelist-wildcard.html http/tests/appcache/disabled.html http/tests/appcache/main-resource-fallback-for-network-error-crash.html http/tests/appcache/reload.html http/tests/appcache/foreign-iframe-main.html http/tests/appcache/main-resource-redirect.html http/tests/appcache/local-content.html http/tests/appcache/top-frame-3.html http/tests/appcache/resource-redirect-2.html http/tests/appcache/wrong-signature-2.html http/tests/appcache/manifest-parsing.html http/tests/appcache/origin-quota-continued-download-multiple-manifests.html http/tests/appcache/origins-with-appcache.html http/tests/appcache/update-cache.html http/tests/appcache/offline-access.html http/tests/security/cross-origin-appcache.html http/tests/appcache/fallback.html

Build Bot

Comment 14 2014-11-13 21:18:15 PST

Created attachment 241551 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 15 2014-11-13 21:36:59 PST

Comment on attachment 241538 [details] Patch for mac ews Attachment 241538 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4595611676442624 Number of test failures exceeded the failure limit.

Build Bot

Comment 16 2014-11-13 21:37:02 PST

Created attachment 241553 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Gyuyoung Kim

Comment 17 2014-11-16 21:15:46 PST

Created attachment 241692 [details] Patch for landing

WebKit Commit Bot

Comment 18 2014-11-16 22:46:24 PST

Comment on attachment 241692 [details] Patch for landing Clearing flags on attachment: 241692 Committed r176172: <http://trac.webkit.org/changeset/176172>

WebKit Commit Bot

Comment 19 2014-11-16 22:46:30 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.