Bug 138560

Summary: Use std::unique_ptr<> and std::make_unique<> in WebCore
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, darin, eric.carlson, esprehn+autocc, glenn, jer.noble, kangil.han, kondapallykalyan, philipj, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2014-11-10 00:03:13 PST
SSIA
Attachments
Patch (6.58 KB, patch)
2014-11-10 00:04 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (4.48 KB, patch)
2014-11-10 06:44 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-11-10 00:04:23 PST
Created attachment 241280 [details] Patch
Gyuyoung Kim
Comment 2 2014-11-10 06:44:29 PST
Created attachment 241289 [details] Patch
WebKit Commit Bot
Comment 3 2014-11-10 06:47:34 PST
Attachment 241289 [details] did not pass style-queue: ERROR: Source/WebCore/dom/ElementIteratorAssertions.h:56: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2014-11-10 14:08:54 PST
Comment on attachment 241289 [details] Patch r=me
WebKit Commit Bot
Comment 5 2014-11-10 17:48:45 PST
Comment on attachment 241289 [details] Patch Clearing flags on attachment: 241289 Committed r175844: <http://trac.webkit.org/changeset/175844>
WebKit Commit Bot
Comment 6 2014-11-10 17:48:50 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 7 2014-11-11 08:42:43 PST
This broke the Windows build: https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29?numbuilds=100
Gyuyoung Kim
Comment 8 2014-11-11 09:07:48 PST
(In reply to comment #7) > This broke the Windows build: > https://build.webkit.org/builders/ > Apple%20Win%20Debug%20%28Build%29?numbuilds=100 Hmm, I need to have time to fix this build error because I don't have win-debug build environment. I'm gonna revert this for now.
Gyuyoung Kim
Comment 9 2014-11-11 09:16:15 PST
Reverted r175844 for reason: Win debug build has broken since r175844 Committed r175939: <http://trac.webkit.org/changeset/175939>
Darin Adler
Comment 10 2015-04-23 22:27:17 PDT
I took care of these a while back. OwnPtr is almost done now!
Note You need to log in before you can comment on or make changes to this bug.