Bug 138434

Summary: Web Inspector: support adding and removing timelines to the timeline sidebar panel and overview
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, madonnk, syoichi, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 136292    
Attachments:
Description Flags
Mock Up
none
dynamically adding timelines
none
Patch (needs rebase)
none
Proposed Fix timothy: review+

Brian Burg
Reported 2014-11-05 12:57:47 PST
This will support workflows where the user can add new profiling "instruments".
Attachments
Mock Up (213.46 KB, image/png)
2014-11-05 13:40 PST, Timothy Hatcher 		no flags
Details
dynamically adding timelines (85.08 KB, image/png)
2015-02-07 23:57 PST, Brian Burg 		no flags
Details
Patch (needs rebase) (108.70 KB, patch)
2015-02-08 00:46 PST, Brian Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (105.77 KB, patch)
2015-02-08 00:55 PST, Brian Burg 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-11-05 12:57:58 PST
<rdar://problem/18884799>
Timothy Hatcher
Comment 2 2014-11-05 13:40:01 PST
Created attachment 241053 [details] Mock Up Here is a mock up on what I thought at the time I was designing the new Timelines view.
Brian Burg
Comment 3 2015-02-07 23:57:19 PST
Created attachment 246234 [details] dynamically adding timelines I have written a patch to dynamically add/remove timelines, and will upload soon. If you want to change the UI (adding opt-in checkboxes, etc0, that can go in a different bug.
Brian Burg
Comment 4 2015-02-08 00:46:02 PST
Created attachment 246237 [details] Patch (needs rebase)
Brian Burg
Comment 5 2015-02-08 00:55:54 PST
Created attachment 246239 [details] Proposed Fix
Timothy Hatcher
Comment 6 2015-02-12 10:22:39 PST
Comment on attachment 246239 [details] Proposed Fix Really nice!
Brian Burg
Comment 7 2015-02-12 11:00:09 PST
Committed r180001: <http://trac.webkit.org/changeset/180001>
Note You need to log in before you can comment on or make changes to this bug.