Bug 137877

Summary: Move std::unique_ptr<>|make_unique<> to WebCore/page/scrolling
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, jamesr, luiz, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2014-10-20 04:27:11 PDT
SSIA
Attachments
Patch (20.42 KB, patch)
2014-10-20 04:28 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (21.27 KB, patch)
2014-10-20 07:04 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (8.36 KB, patch)
2015-02-22 05:04 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-10-20 04:28:11 PDT
Created attachment 240110 [details] Patch
Gyuyoung Kim
Comment 2 2014-10-20 07:04:17 PDT
Created attachment 240119 [details] Patch
Darin Adler
Comment 3 2014-10-20 09:57:59 PDT
Comment on attachment 240119 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240119&action=review > Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:118 > - OwnPtr<ScrollingStateTree> treeState = scrollingStateTree()->commit(LayerRepresentation::PlatformLayerRepresentation); > + std::unique_ptr<ScrollingStateTree> treeState = scrollingStateTree()->commit(LayerRepresentation::PlatformLayerRepresentation); This doesn’t compile yet: /Volumes/Data/EWS/WebKit/Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:119:31: error: no viable conversion from '__bind<void (WebCore::ThreadedScrollingTree::*)(std::__1::unique_ptr<WebCore::ScrollingStateTree, std::__1::default_delete<WebCore::ScrollingStateTree> >), WebCore::ThreadedScrollingTree *, WebCore::ScrollingStateTree *>' to 'std::function<void ()>' I don’t know exactly what’s wrong.
Gyuyoung Kim
Comment 4 2014-12-24 08:11:26 PST
*** Bug 138203 has been marked as a duplicate of this bug. ***
Gyuyoung Kim
Comment 5 2015-02-22 05:04:25 PST
Created attachment 247082 [details] Patch
WebKit Commit Bot
Comment 6 2015-02-22 18:38:36 PST
Comment on attachment 247082 [details] Patch Clearing flags on attachment: 247082 Committed r180493: <http://trac.webkit.org/changeset/180493>
WebKit Commit Bot
Comment 7 2015-02-22 18:38:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.