Bug 137774

Summary: Fix FTL Native Inlining for EFL
Product: WebKit Reporter: Dániel Bátyai <dbatyai.u-szeged>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, darin, fpizlo, gyuyoung.kim, lantw44, mark.lam, msaboff, mtiborinf, ossy, rakuco, ryuan.choi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145044    
Bug Blocks: 143605    
Attachments:
Description Flags
Patch
none
Patch none

Dániel Bátyai
Reported 2014-10-16 02:26:57 PDT
Fix FTL Native Inlining for EFL
Attachments
Patch (18.18 KB, patch)
2014-10-16 02:41 PDT, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Patch (24.48 KB, patch)
2014-10-16 04:35 PDT, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dániel Bátyai
Comment 1 2014-10-16 02:41:29 PDT
Created attachment 239940 [details] Patch Initial WIP. Added required functionality and updated CMake to generate the required bitcode. There is a small issue with the script generating InlineRuntmeSymbolTable.h, but overall the inlining is working correctly.
Dániel Bátyai
Comment 2 2014-10-16 04:35:48 PDT
Created attachment 239943 [details] Patch Added missing files
WebKit Commit Bot
Comment 3 2014-10-16 04:38:19 PDT
Attachment 239943 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/CMakeLists.txt:795: There should be exactly one empty line instead of 0 between "inspector" and "inspector/agents". [list/emptyline] [5] ERROR: Source/JavaScriptCore/CMakeLists.txt:797: Alphabetical sorting problem. "interpreter" should be before "inspector/remote". [list/order] [5] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Saboff
Comment 4 2014-10-20 10:01:05 PDT
Comment on attachment 239943 [details] Patch r=me
WebKit Commit Bot
Comment 5 2014-10-21 03:18:12 PDT
Comment on attachment 239943 [details] Patch Clearing flags on attachment: 239943 Committed r174940: <http://trac.webkit.org/changeset/174940>
WebKit Commit Bot
Comment 6 2014-10-21 03:18:21 PDT
All reviewed patches have been landed. Closing bug.
Ting-Wei Lan
Comment 7 2014-10-21 07:11:21 PDT
This patch causes compilation error on FreeBSD 10.1. program_invocation_name is a GNU extension, so it should not be used unconditionally. Source/JavaScriptCore/runtime/BundlePath.cpp:41:42: error: use of undeclared identifier 'program_invocation_name' std::string programPath(realpath(program_invocation_name, 0)); ^ 1 error generated.
Tibor Mészáros
Comment 8 2014-10-21 08:47:05 PDT
(In reply to comment #7) > This patch causes compilation error on FreeBSD 10.1. program_invocation_name > is a GNU extension, so it should not be used unconditionally. > > Source/JavaScriptCore/runtime/BundlePath.cpp:41:42: error: use of undeclared > identifier 'program_invocation_name' > std::string programPath(realpath(program_invocation_name, 0)); > ^ > 1 error generated. Hi Ting-Wei Lan! https://bugs.webkit.org/show_bug.cgi?id=137924 will fix this problem.
Note You need to log in before you can comment on or make changes to this bug.