Bug 137673

Summary: [Win] Implement a page load profiling tool
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200155
Attachments:
Description Flags
Patch dino: review+

Brent Fulgham
Reported 2014-10-13 14:27:22 PDT
Implement a page load profiling tool for Windows, based on the PLT tool and WinLauncher.
Attachments
Patch (46.98 KB, patch)
2014-10-13 15:26 PDT, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-10-13 14:52:26 PDT
<rdar://problem/18639562>
Brent Fulgham
Comment 2 2014-10-13 15:26:56 PDT
Created attachment 239751 [details] Patch
WebKit Commit Bot
Comment 3 2014-10-13 15:29:47 PDT
Attachment 239751 [details] did not pass style-queue: ERROR: Tools/WinLauncher/PageLoadTestClient.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WinLauncher/PageLoadTestClient.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WinLauncher/PageLoadTestClient.cpp:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WinLauncher/ResourceLoadDelegate.cpp:25: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/WinLauncher/ResourceLoadDelegate.cpp:26: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 5 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 4 2014-10-13 15:30:39 PDT
Note: These style errors are due to required include ordering on Windows. :-(
Dean Jackson
Comment 5 2014-10-13 15:36:02 PDT
Comment on attachment 239751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239751&action=review > Tools/WinLauncher/PageLoadTestClient.cpp:197 > +#if PLATFORM(WIN) Do you need this? Isn't WinLauncher windows only?
Brent Fulgham
Comment 6 2014-10-13 15:47:13 PDT
Comment on attachment 239751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239751&action=review >> Tools/WinLauncher/PageLoadTestClient.cpp:197 >> +#if PLATFORM(WIN) > > Do you need this? Isn't WinLauncher windows only? I'm also making some changes in MiniBrowser that will use this code.
Brent Fulgham
Comment 7 2014-10-13 16:10:45 PDT
Committed r174664: <http://trac.webkit.org/changeset/174664>
Note You need to log in before you can comment on or make changes to this bug.