Bug 137255

Summary: Web Inspector: new breakpoint action dialog should reuse same action type
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, mattbaker, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 136292    
Attachments:
Description Flags
[Patch] Proposed Fix none

Brian Burg
Reported 2014-09-30 10:55:10 PDT
When you add multiple actions to a breakpoint using the [+] button, the drop-down for action type always starts with the first value. It should copy the type of the previous action. This will make it less tedious to add multiple probes from the breakpoint actions dialog.
Attachments
[Patch] Proposed Fix (1.67 KB, patch)
2015-07-08 23:19 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-09-30 10:55:35 PDT
<rdar://problem/18502769>
Matt Baker
Comment 2 2015-07-07 13:36:03 PDT
This would be different from Xcode's behavior, which defaults to Debugger Command every time. Their action list differs from ours, but I assume this is considered to be the most commonly used command (it's not the first in the list).
Timothy Hatcher
Comment 3 2015-07-07 13:40:18 PDT
Yeah, I think we should do this. I've considered a similar change in the past.
Matt Baker
Comment 4 2015-07-08 23:19:18 PDT
Created attachment 256462 [details] [Patch] Proposed Fix
Brian Burg
Comment 5 2015-07-09 00:07:56 PDT
Comment on attachment 256462 [details] [Patch] Proposed Fix r=me
WebKit Commit Bot
Comment 6 2015-07-09 00:36:20 PDT
Comment on attachment 256462 [details] [Patch] Proposed Fix Clearing flags on attachment: 256462 Committed r186588: <http://trac.webkit.org/changeset/186588>
WebKit Commit Bot
Comment 7 2015-07-09 00:36:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.