Bug 137079
| Summary: | Web Inspector: don't suppress breakpoints when emptying the call stack prior to replay | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED LATER | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 137078 | ||
Brian Burg
The ReplayManager tries to temporarily suppress breakpoints before (re-)starting replay and resumes the debugger in case the debugger is paused. This interacts poorly with time-indexed outputs because starting playback will race with unsuppressing breakpoints, and some breakpoint hits may be missed.
Instead, we should probably just issue Debugger.stepOut commands until nothing is left in the call stack, and then restart replay.
There may be some way to blow over the call stack using exceptions or something, but this could have a lot of unwanted side effects in the UI.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Timothy Hatcher
Maybe the best fix on on the backend? ReplayAgent can talk directly to the debugger and only pause when needed.
Radar WebKit Bug Importer
<rdar://problem/18450892>
Blaze Burg
Closing web replay-related bugs until we resume working on the feature again.