Bug 136359
| Summary: | move emissions of op_profile_type out of BytecodeGenerator::emitMove | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> |
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | joepeck |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Saam Barati
Currently, this will emit an op_profile_type if it sees that the destination register isn't a temporary.
And in NodesCodegen, after these emitMove calls, there will be calls to generator::emitTypeProfilerExpressionInfo.
But, just by reading the code in NodesCodegen, it's confusing why this expression info is emitted.
It's better to just inline the emission of op_profile_type everywhere emitTypeProfilerExpressionInfo is called.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Saam Barati
this was done in:
http://trac.webkit.org/changeset/187524