Bug 136213

Summary: [GTK] Add WaylandEventSource
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, mrobinson, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 115803    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch mrobinson: review+

Zan Dobersek
Reported 2014-08-25 02:58:21 PDT
[GTK] Add WaylandEventSource
Attachments
Patch (7.38 KB, patch)
2014-08-25 03:12 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (7.90 KB, patch)
2014-08-25 12:49 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (8.22 KB, patch)
2014-08-28 00:32 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (8.29 KB, patch)
2014-08-28 00:52 PDT, Zan Dobersek 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-08-25 03:12:10 PDT
Created attachment 237070 [details] Patch
Zan Dobersek
Comment 2 2014-08-25 12:49:13 PDT
Created attachment 237100 [details] Patch
Martin Robinson
Comment 3 2014-08-26 10:55:38 PDT
Comment on attachment 237100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237100&action=review I think you should consider a design where the callbacks are just stubs that call methods on GlibSource. I think that's a common pattern we use for these callback structs in WebKit2. > Source/WebCore/platform/graphics/wayland/WaylandEventSource.h:45 > + struct GLibSource { > + GSource source; > + GPollFD pfd; > + struct wl_display* display; > + }; Does this need to be exposed in the class definition?
Zan Dobersek
Comment 4 2014-08-28 00:32:34 PDT
Created attachment 237297 [details] Patch Uses non-lambda callbacks that relay the task to the GLibSource object.
Zan Dobersek
Comment 5 2014-08-28 00:52:58 PDT
Created attachment 237298 [details] Patch
Martin Robinson
Comment 6 2014-08-28 10:15:37 PDT
Comment on attachment 237297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237297&action=review > Source/WebCore/platform/graphics/wayland/WaylandEventSource.cpp:42 > + GPollFD m_pfd; m_pfd is hard to understand without seeing the definition here. Perhaps m_pollFileDescriptor would be better? > Source/WebCore/platform/graphics/wayland/WaylandEventSource.cpp:67 > + Extra line here.
Martin Robinson
Comment 7 2014-08-28 10:16:14 PDT
Comment on attachment 237298 [details] Patch Looks great! Thanks for updating it. Please fix the small nits before landing.
Zan Dobersek
Comment 8 2014-08-28 13:20:33 PDT
Committed r173068: <http://trac.webkit.org/changeset/173068>
Note You need to log in before you can comment on or make changes to this bug.