Bug 136028

Summary: REGRESSION(r163179): It broke the build on ARM Thumb2 with GCC
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Blocker CC: clopez, fpizlo, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, oliver, ossy, zan
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645, 131578    
Attachments:
Description Flags
Patch oliver: review+

Csaba Osztrogonác
Reported 2014-08-17 12:49:44 PDT
See https://bugs.webkit.org/show_bug.cgi?id=131578 for details. Feel free to pick it up, I won't have time for it in the near future.
Attachments
Patch (4.01 KB, patch)
2014-08-18 22:48 PDT, Michael Saboff 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2014-08-18 09:16:30 PDT
Working on patch. Will post later today.
Michael Saboff
Comment 2 2014-08-18 22:48:16 PDT
Created attachment 236802 [details] Patch
Csaba Osztrogonác
Comment 3 2014-08-18 23:55:18 PDT
Thanks for fixing this bug. I tried the patch, and there is one more remaining build failure with it: LowLevelInterpreter.s: Assembler messages: LowLevelInterpreter.s:1514: Error: r13 not allowed here -- `subs sp,r7,#48' .LhandleUncaughtException: ldr r4, [r7, #16] movw r12, #0 movt r12, #65535 ands r4, r12 ldr r4, [r4, #1076] movw r12, #26908 add r12, r4 ldr r7, [r12, #0] ldr r7, [r7, #0] subs sp, r7, #48 <---------- line 1514 subs r4, r7, #48 mov sp, r4 ldr r4, [sp, #0] ldr r9, [sp, #4] movw r12, #22952 add r12, r4 str r9, [r12, #0] ldr r9, [sp, #8] movw r12, #22948 add r12, r4 str r9, [r12, #0] subs r4, r7, #28 mov sp, r4 pop {r4-r6, r8-r11} pop { r7 } pop { lr } bx lr
Csaba Osztrogonác
Comment 4 2014-08-18 23:58:22 PDT
Comment on attachment 236802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236802&action=review > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:405 > vmEntryRecord(cfr, sp) I think this line should be removed.
Csaba Osztrogonác
Comment 5 2014-08-19 00:15:27 PDT
Committed r172746: <http://trac.webkit.org/changeset/172746>
Csaba Osztrogonác
Comment 6 2014-08-19 00:16:51 PDT
(In reply to comment #5) > Committed r172746: <http://trac.webkit.org/changeset/172746> I landed the patch with the typo fix mentioned in Comment #4. (build and tests works fine)
Michael Saboff
Comment 7 2014-08-19 12:11:44 PDT
Comment on attachment 236802 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236802&action=review >> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:405 >> vmEntryRecord(cfr, sp) > > I think this line should be removed. Yep. Thanks.
Note You need to log in before you can comment on or make changes to this bug.