Bug 135978

Summary: Turn r/rx/ry to presentation attributes
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 135045    
Attachments:
Description Flags
Patch
dino: review+
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion none

Dirk Schulze
Reported 2014-08-15 09:29:12 PDT
Turn r/rx/ry to presentation attributes
Attachments
Patch (39.73 KB, patch)
2014-08-15 09:34 PDT, Dirk Schulze 		dino: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (794.42 KB, application/zip)
2014-08-15 11:34 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (935.98 KB, application/zip)
2014-08-15 12:36 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2014-08-15 09:34:35 PDT
Created attachment 236650 [details] Patch
Dirk Schulze
Comment 2 2014-08-15 09:36:02 PDT
The patch depends on bug 135975 and won't compile until the patch on the bug landed.
Build Bot
Comment 3 2014-08-15 11:34:47 PDT
Created attachment 236660 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Dean Jackson
Comment 4 2014-08-15 11:45:41 PDT
Comment on attachment 236650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236650&action=review It seems this has much of the original cx/cy patch in it. Assuming that is removed when the cx/cy lands... r=me > Source/WebCore/ChangeLog:64 > +2014-08-15 Dirk Schulze <krit@webkit.org> > + > + Turn cx/cy to presentation attributes > + https://bugs.webkit.org/show_bug.cgi?id=135975 > + > + Reviewed by NOBODY (OOPS!). > + > + This follows the patch for width and height presentation attributes and > + turns x and y to presentation attributes as well: > + ChangeLog has the previous patch in it as well. > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:408 > + CSSPropertyCx, > + CSSPropertyCy, Oops. > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2977 > + case CSSPropertyCx: > + return zoomAdjustedPixelValueForLength(style->svgStyle().cx(), style.get()); > + case CSSPropertyCy: > + return zoomAdjustedPixelValueForLength(style->svgStyle().cy(), style.get()); Oops. > LayoutTests/ChangeLog:22 > +2014-08-15 Dirk Schulze <krit@webkit.org> > + > + Turn cx/cy to presentation attributes > + https://bugs.webkit.org/show_bug.cgi?id=135975 > + > + Reviewed by NOBODY (OOPS!). More Oops.
Build Bot
Comment 5 2014-08-15 12:36:26 PDT
Created attachment 236669 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Dirk Schulze
Comment 6 2014-08-15 12:43:00 PDT
Committed r172642: <http://trac.webkit.org/changeset/172642>
Dirk Schulze
Comment 7 2014-08-15 13:49:01 PDT
Committed r172647: <http://trac.webkit.org/changeset/172647>
Note You need to log in before you can comment on or make changes to this bug.