Bug 134255

Summary: Enable GAMEPAD in the Mac build, disabled at runtime
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, cgarcia, commit-queue, dino, esprehn+autocc, gyuyoung.kim, kondapallykalyan, mhahnenberg, sergio, syoichi, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 134076    
Attachments:
Description Flags
Patch v1
none
Patch v2 - Without the Shader.h change (why is it even in there?)
none
Patch v3 - Better feature defines (mac-only)
none
Patch v3 (take 2) - Same patch again, but EWSs should be in better shape now.
dino: review+
Patch for landing v1 none

Brady Eidson
Reported 2014-06-24 11:04:16 PDT
Enable GAMEPAD in the Mac build but disabled at runtime. This will help with patches coming soon by allowing EWS/commit queue to see build failures. It will also be nice to not have to enable it locally after an update, always causing a full rebuild.
Attachments
Patch v1 (19.86 KB, patch)
2014-06-24 11:10 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v2 - Without the Shader.h change (why is it even in there?) (18.00 KB, patch)
2014-06-24 11:14 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v3 - Better feature defines (mac-only) (18.30 KB, patch)
2014-06-24 12:07 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v3 (take 2) - Same patch again, but EWSs should be in better shape now. (18.30 KB, patch)
2014-06-24 13:45 PDT, Brady Eidson 		dino: review+
DetailsFormatted DiffDiff
Patch for landing v1 (18.55 KB, patch)
2014-06-24 15:16 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-06-24 11:10:21 PDT
Created attachment 233718 [details] Patch v1
Brady Eidson
Comment 2 2014-06-24 11:14:26 PDT
Created attachment 233719 [details] Patch v2 - Without the Shader.h change (why is it even in there?)
Brady Eidson
Comment 3 2014-06-24 11:24:19 PDT
Removed Shader.h from the project file once-and-for-all in 170374
Brady Eidson
Comment 4 2014-06-24 12:07:55 PDT
Created attachment 233728 [details] Patch v3 - Better feature defines (mac-only)
Brady Eidson
Comment 5 2014-06-24 13:45:23 PDT
Created attachment 233736 [details] Patch v3 (take 2) - Same patch again, but EWSs should be in better shape now.
Dean Jackson
Comment 6 2014-06-24 14:42:27 PDT
Comment on attachment 233736 [details] Patch v3 (take 2) - Same patch again, but EWSs should be in better shape now. Seems to still be some compile errors on other ports.
Brady Eidson
Comment 7 2014-06-24 14:47:31 PDT
Will figure out EWS on other ports before landing. Windows, at least, is not related - that EWS is just hosed.
Brady Eidson
Comment 8 2014-06-24 14:49:53 PDT
NM, quite real compile errors. will fix.
Brady Eidson
Comment 9 2014-06-24 15:16:19 PDT
Created attachment 233750 [details] Patch for landing v1 The additional bindings code needed #if ENABLE() guards If this passes EWS we're good.
WebKit Commit Bot
Comment 10 2014-06-24 16:17:50 PDT
Comment on attachment 233750 [details] Patch for landing v1 Clearing flags on attachment: 233750 Committed r170400: <http://trac.webkit.org/changeset/170400>
WebKit Commit Bot
Comment 11 2014-06-24 16:17:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.