Bug 132341

Summary: [CSS Grid Layout] Wrap some specific grid code under compilation flag
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: New BugsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, esprehn+autocc, glenn, kling, kondapallykalyan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch
none
Path for landing. none

Manuel Rego Casasnovas
Reported 2014-04-29 09:55:44 PDT
[CSS Grid Layout] Wrap some specific grid code under compilation flag
Attachments
Patch (5.60 KB, patch)
2014-04-29 09:56 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (5.62 KB, patch)
2014-04-29 09:58 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Path for landing. (5.77 KB, patch)
2014-04-30 00:45 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2014-04-29 09:56:22 PDT
Created attachment 230383 [details] Patch
Manuel Rego Casasnovas
Comment 2 2014-04-29 09:58:08 PDT
Created attachment 230384 [details] Patch Re-upload with the bug link in the ChangeLog entry.
Benjamin Poulain
Comment 3 2014-04-30 00:08:16 PDT
Comment on attachment 230384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230384&action=review Looks like a good idea. > Source/WebCore/rendering/RenderBox.cpp:80 > static OverrideSizeMap* gOverrideContainingBlockLogicalHeightMap = 0; > static OverrideSizeMap* gOverrideContainingBlockLogicalWidthMap = 0; You can also replace those zero by nullptr.
Manuel Rego Casasnovas
Comment 4 2014-04-30 00:45:16 PDT
Created attachment 230468 [details] Path for landing.
WebKit Commit Bot
Comment 5 2014-04-30 01:23:28 PDT
Comment on attachment 230468 [details] Path for landing. Clearing flags on attachment: 230468 Committed r167988: <http://trac.webkit.org/changeset/167988>
WebKit Commit Bot
Comment 6 2014-04-30 01:23:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.