Bug 131560

Summary: Support document-relative and custom-frame page overlays
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, alice.barraclough, commit-queue, esprehn+autocc, glenn, kondapallykalyan, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 131510    
Attachments:
Description Flags
patch
none
patch simon.fraser: review+

Tim Horton
Reported 2014-04-11 13:41:12 PDT
Most page overlays are really document overlays.
Attachments
patch (32.00 KB, patch)
2014-04-11 14:08 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (32.19 KB, patch)
2014-04-11 14:10 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-04-11 13:41:35 PDT
<rdar://problem/16595556>
Tim Horton
Comment 2 2014-04-11 14:08:36 PDT
Created attachment 229160 [details] patch
Tim Horton
Comment 3 2014-04-11 14:10:36 PDT
Created attachment 229161 [details] patch
WebKit Commit Bot
Comment 4 2014-04-11 14:11:32 PDT
Attachment 229161 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderLayerCompositor.h:307: The parameter name "documentOverlayRootLayer" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/WebProcess/WebPage/PageOverlay.h:95: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 5 2014-04-11 14:17:47 PDT
Comment on attachment 229161 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=229161&action=review > Source/WebKit2/WebProcess/WebPage/PageOverlayController.cpp:104 > + if (overlay->overlayType() == PageOverlay::OverlayType::View) { > + if (Page* page = m_webPage->corePage()) { > + if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator()) > + scrollingCoordinator->setForceSynchronousScrollLayerPositionUpdates(true); > + } Why not just call updateForceSynchronousScrollLayerPositionUpdates()? > Source/WebKit2/WebProcess/WebPage/PageOverlayController.h:38 > +namespace WebCore { > +class Frame; > +} Remove. You just use WebCore::Frame below.
Tim Horton
Comment 6 2014-04-11 14:42:11 PDT
http://trac.webkit.org/changeset/167152
Note You need to log in before you can comment on or make changes to this bug.