Bug 131064

Summary: [CSS Grid Layout] Split the grid-item-margin-auto-columns-rows.html test.
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, jfernandez, kling, rego, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch
none
Patch none

Javier Fernandez
Reported Tuesday, April 1, 2014 10:20:16 PM UTC
Reference tests do have a limitation in that they only work if the test result fits into a relatively small-sized window. Splitting this test in two, horizontal and vertical layout, would be enough to make it fit in the 800x600 viewport.
Attachments
Patch (28.25 KB, patch)
2014-04-01 16:04 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (37.58 KB, patch)
2014-05-22 03:28 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 Wednesday, April 2, 2014 12:04:55 AM UTC
Created attachment 228333 [details] Patch
Javier Fernandez
Comment 2 Wednesday, April 30, 2014 10:07:26 PM UTC
Darin, what do you think about the new tests ?
Javier Fernandez
Comment 3 Tuesday, May 6, 2014 7:00:49 PM UTC
ping reviewers.
Javier Fernandez
Comment 4 Thursday, May 22, 2014 10:21:00 AM UTC
Ping reviewers. Thanks.
Benjamin Poulain
Comment 5 Thursday, May 22, 2014 10:46:33 AM UTC
Comment on attachment 228333 [details] Patch Splitting text seems like a good idea. Just rename the horiz and vert to horizontal and vertical. No point in abbreviating. Shouldn't grid-item-margin-auto-columns-rows be named horizontal-ltr for consistency? Does it test something else?
Javier Fernandez
Comment 6 Thursday, May 22, 2014 11:28:28 AM UTC
Created attachment 231874 [details] Patch Renamed horiz and vert to horizontal and vertical. The basic test was renamed to horitonzal-ltr for consistency, as suggested.
WebKit Commit Bot
Comment 7 Thursday, May 22, 2014 1:02:03 PM UTC
Comment on attachment 231874 [details] Patch Clearing flags on attachment: 231874 Committed r169197: <http://trac.webkit.org/changeset/169197>
WebKit Commit Bot
Comment 8 Thursday, May 22, 2014 1:02:07 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.