Bug 130722

Summary: Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in editing/
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 130185    
Attachments:
Description Flags
Patch
none
Patch koivisto: review+

Sergio Villar Senin
Reported 2014-03-25 09:55:56 PDT
Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in editing/
Attachments
Patch (21.40 KB, patch)
2014-03-25 09:57 PDT, Sergio Villar Senin 		no flags
DetailsFormatted DiffDiff
Patch (22.23 KB, patch)
2014-03-26 07:25 PDT, Sergio Villar Senin 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2014-03-25 09:57:57 PDT
Created attachment 227763 [details] Patch
Darin Adler
Comment 2 2014-03-25 20:31:39 PDT
Comment on attachment 227763 [details] Patch EWS bots show that we need more get() calls in AlternativeTextController.cpp
Sergio Villar Senin
Comment 3 2014-03-26 07:25:14 PDT
Created attachment 227849 [details] Patch
Antti Koivisto
Comment 4 2014-03-26 07:39:02 PDT
Comment on attachment 227849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227849&action=review > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:66 > + oldObject.get() = 0; nullptr > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:69 > + AtkObject* oldAxObject = oldObject.get() ? oldObject.get()->wrapper() : 0; nullptr
Sergio Villar Senin
Comment 5 2014-03-26 08:13:22 PDT
Committed r166294: <http://trac.webkit.org/changeset/166294>
Note You need to log in before you can comment on or make changes to this bug.