Bug 130601

Summary: Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in bridge/
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, darin, kling, mjs, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 130185    
Attachments:
Description Flags
Patch darin: review+

Sergio Villar Senin
Reported 2014-03-21 09:48:25 PDT
Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in bridge/
Attachments
Patch (5.57 KB, patch)
2014-03-21 09:53 PDT, Sergio Villar Senin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2014-03-21 09:53:31 PDT
Created attachment 227448 [details] Patch
Darin Adler
Comment 2 2014-03-21 10:00:01 PDT
Comment on attachment 227448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227448&action=review > Source/WebCore/bridge/runtime_root.cpp:65 > - RootObjectSet::const_iterator end = rootObjectSet()->end(); > - for (RootObjectSet::const_iterator it = rootObjectSet()->begin(); it != end; ++it) { > + RootObjectSet::const_iterator end = rootObjectSet().end(); > + for (RootObjectSet::const_iterator it = rootObjectSet().begin(); it != end; ++it) { > if ((*it)->gcIsProtected(jsObject)) > return *it; > } I would’ve switched to a new style for loop if I had to touch this code for another reason. for (auto* rootObject : rootObjectSet()) { if (rootObject->gcIsProtected(jsObject)) return rootObject; } > Source/WebCore/bridge/runtime_root.cpp:75 > - RootObjectSet::const_iterator end = rootObjectSet()->end(); > - for (RootObjectSet::const_iterator it = rootObjectSet()->begin(); it != end; ++it) { > + RootObjectSet::const_iterator end = rootObjectSet().end(); > + for (RootObjectSet::const_iterator it = rootObjectSet().begin(); it != end; ++it) { > if ((*it)->globalObject() == globalObject) > return *it; > } I would’ve switched to a new style for loop if I had to touch this code for another reason. for (auto* rootObject : rootObjectSet()) { if (rootObject->globalObject() == globalObject) return rootObject; }
Sergio Villar Senin
Comment 3 2014-03-21 10:32:44 PDT
Committed r166071: <http://trac.webkit.org/changeset/166071>
Note You need to log in before you can comment on or make changes to this bug.