Bug 130574

Summary: [CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled
Product: WebKit Reporter: Radu Stavila <stavila>
Component: CSSAssignee: Radu Stavila <stavila>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Test-case
none
Patch
none
Patch
hyatt: review-
Patch integrating feedback none

Radu Stavila
Reported 2014-03-21 02:50:39 PDT
Created attachment 227406 [details] Test-case The background of children of elements flowed into scrollable regions is not properly scrolled. See attached test-case.
Attachments
Test-case (809 bytes, text/html)
2014-03-21 02:50 PDT, Radu Stavila 		no flags
Details
Patch (7.64 KB, patch)
2014-03-21 07:15 PDT, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2014-03-21 07:31 PDT, Radu Stavila 		hyatt: review-
DetailsFormatted DiffDiff
Patch integrating feedback (12.85 KB, patch)
2014-03-21 09:20 PDT, Radu Stavila 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radu Stavila
Comment 1 2014-03-21 07:15:35 PDT
Created attachment 227432 [details] Patch
Radu Stavila
Comment 2 2014-03-21 07:31:31 PDT
Created attachment 227433 [details] Patch
Dave Hyatt
Comment 3 2014-03-21 08:43:45 PDT
Comment on attachment 227433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227433&action=review > Source/WebCore/rendering/RenderNamedFlowThread.cpp:307 > + // Take the scrolled offset of this object's parents into consideration. > + IntSize scrolledContentOffset; > + RenderElement* parent = box.parent(); > + while (parent) { > + if (parent->isBox()) { > + RenderBox* parentBox = toRenderBox(parent); > + if (parentBox->isRenderNamedFlowThread()) { Don't we have a function to get the enclosing named flow thread for a box? Pretty sure we do, in which case writing this loop yourself seems like extra code?
Radu Stavila
Comment 4 2014-03-21 09:20:08 PDT
Created attachment 227443 [details] Patch integrating feedback
Dave Hyatt
Comment 5 2014-03-25 14:04:23 PDT
Comment on attachment 227443 [details] Patch integrating feedback r=me
WebKit Commit Bot
Comment 6 2014-03-25 15:01:52 PDT
Comment on attachment 227443 [details] Patch integrating feedback Clearing flags on attachment: 227443 Committed r166259: <http://trac.webkit.org/changeset/166259>
WebKit Commit Bot
Comment 7 2014-03-25 15:01:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.