Bug 130506

Summary: [EFL] Add ARM64 build support
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bunhere, cmarcelo, commit-queue, dbates, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, ossy, rakuco, sergio, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Bug Depends on: 130453, 130454, 130500, 130502    
Bug Blocks:    
Attachments:
Description Flags
proposed patch none

Gabor Rapcsanyi
Reported 2014-03-20 05:59:27 PDT
Add ARM64 build support to EFL port.
Attachments
proposed patch (4.18 KB, patch)
2014-03-20 06:35 PDT, Gabor Rapcsanyi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2014-03-20 06:35:24 PDT
Created attachment 227285 [details] proposed patch
Gyuyoung Kim
Comment 2 2014-03-24 16:38:36 PDT
Comment on attachment 227285 [details] proposed patch rs=me. However, it would be nicer if JS guys take a final look before landing.
Zoltan Herczeg
Comment 3 2014-03-25 05:46:49 PDT
Comment on attachment 227285 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=227285&action=review > Source/WTF/wtf/Platform.h:155 > +#if defined(__arm64__) && defined(__APPLE__) || defined(__aarch64__) I would put a bracket around the && part.
Gabor Rapcsanyi
Comment 4 2014-03-25 06:14:29 PDT
Thanks for the review, I changed what Zoltan suggested. Patch landed: http://trac.webkit.org/changeset/166232
Gyuyoung Kim
Comment 5 2014-03-25 22:45:40 PDT
Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture.
Gabor Rapcsanyi
Comment 6 2014-03-26 00:28:08 PDT
(In reply to comment #5) > Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture. Yes, the EFL port is now building for ARM64 and also we have an EFL ARM64 builder bot here: http://build.webkit.sed.hu/waterfall We have some problems with the dependencies so they are built by hand now. If we can solve this in the future we can connect this bot to the Apple master.
Gyuyoung Kim
Comment 7 2014-03-26 00:29:34 PDT
(In reply to comment #6) > (In reply to comment #5) > > Thank you for great work for EFL port. BTW, I wonder whether EFL ARM bot compiles EFL port based on ARM64 architecture. > > Yes, the EFL port is now building for ARM64 and also we have an EFL ARM64 builder bot here: http://build.webkit.sed.hu/waterfall > > We have some problems with the dependencies so they are built by hand now. If we can solve this in the future we can connect this bot to the Apple master. Nice. I hope to see it on build.webkit.org in near future. Thanks a lot !
Note You need to log in before you can comment on or make changes to this bug.