Bug 130300

Summary: Add CompareStrictEq(StringIdent:, NotStringVar:) and CompareStrictEq(String:, Untyped:)
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, kling, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 130449    
Bug Blocks: 112840    
Attachments:
Description Flags
work in progress
none
moar!
none
getting there
none
basically done
none
the patch mhahnenberg: review+

Filip Pizlo
Reported 2014-03-15 23:14:07 PDT
Patch forthcoming.
Attachments
work in progress (12.71 KB, patch)
2014-03-16 17:57 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
moar! (32.42 KB, patch)
2014-03-16 18:24 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
getting there (55.12 KB, patch)
2014-03-16 21:28 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
basically done (72.28 KB, patch)
2014-03-17 21:53 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (72.35 KB, patch)
2014-03-18 12:35 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-03-16 17:57:30 PDT
Created attachment 226867 [details] work in progress
Filip Pizlo
Comment 2 2014-03-16 18:24:55 PDT
Created attachment 226868 [details] moar!
Filip Pizlo
Comment 3 2014-03-16 18:27:08 PDT
I'm using this as an opportunity to add is-cell/is-not-cell/is-other/is-not-other branch abstractions to deduplicate more 64-bit/32-bit code.
Filip Pizlo
Comment 4 2014-03-16 21:28:47 PDT
Created attachment 226876 [details] getting there I wrote all of the DFG code, but there is still some FTL code to write.
Filip Pizlo
Comment 5 2014-03-17 21:53:55 PDT
Created attachment 227011 [details] basically done
Filip Pizlo
Comment 6 2014-03-18 12:35:14 PDT
Created attachment 227089 [details] the patch
Mark Hahnenberg
Comment 7 2014-03-18 13:37:35 PDT
Comment on attachment 227089 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=227089&action=review r=me > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3859 > + JITCompiler::JumpList fastSlow; fastFalse
Filip Pizlo
Comment 8 2014-03-18 13:54:17 PDT
Landed in http://trac.webkit.org/changeset/165842
Csaba Osztrogonác
Comment 9 2014-03-19 04:14:03 PDT
(In reply to comment #8) > Landed in http://trac.webkit.org/changeset/165842 It caused regression on 32 bit x86 - https://bugs.webkit.org/show_bug.cgi?id=130449
Note You need to log in before you can comment on or make changes to this bug.