Bug 130133

Created attachment 226513 [details] proposed patch

Comment on attachment 226513 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=226513&action=review > Source/WebKit2/UIProcess/API/efl/ewk_context.h:79 > + * @brief Contains option for process model It would be better to add more description for each process model. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:117 > + ASSERT_EQ(EWK_PROCESS_MODEL_SHARED_SECONDARY, ewk_context_process_model_get(context)); Could you add more test for 'EWK_PROCESS_MODEL_MULTIPLE_SECONDARY' model? Also, is there any way to check if the network process is forked successfully?

(In reply to comment #2) > (From update of attachment 226513 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226513&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_context.h:79 > > + * @brief Contains option for process model > > It would be better to add more description for each process model. The descriptions of these two options will be extended. > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:117 > > + ASSERT_EQ(EWK_PROCESS_MODEL_SHARED_SECONDARY, ewk_context_process_model_get(context)); > > Could you add more test for 'EWK_PROCESS_MODEL_MULTIPLE_SECONDARY' model? We are working on the tests of this API, so they will be added in the beginning of next week. > Also, is there any way to check if the network process is forked successfully? Yes,it is possible to check this.

(In reply to comment #2) > (From update of attachment 226513 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=226513&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_context.h:79 > > + * @brief Contains option for process model > > It would be better to add more description for each process model. > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:117 > > + ASSERT_EQ(EWK_PROCESS_MODEL_SHARED_SECONDARY, ewk_context_process_model_get(context)); > > Could you add more test for 'EWK_PROCESS_MODEL_MULTIPLE_SECONDARY' model? > Also, is there any way to check if the network process is forked successfully? It is possible but it needs a separate test as process model can be changed only before first WebProcess is spawned.

Created attachment 227643 [details] updated documentation

Comment on attachment 227643 [details] updated documentation View in context: https://bugs.webkit.org/attachment.cgi?id=227643&action=review I'm happy now we can select web process model. LGTM except for my trivial comments. Please fix them before landing. > Source/WebKit2/UIProcess/API/efl/ewk_context.h:384 > + * web process. When EWK_PROCESS_MODEL_MULTIPLY_SECONDARY is set a Typo: EWK_PROCESS_MODEL_MULTIPLY_SECONDARY -> EWK_PROCESS_MODEL_MULTIPLE_SECONDARY. I wonder whether current our process model only supports network process. Won't we support database process ?

Comment on attachment 227643 [details] updated documentation View in context: https://bugs.webkit.org/attachment.cgi?id=227643&action=review > Source/WebKit2/UIProcess/API/efl/ewk_context.h:388 > + * @param context context object to set process model. One more thing. We haven't used "." at the end of @param and @return lines. > Source/WebKit2/UIProcess/API/efl/ewk_context.h:389 > + * @param process_model a #Ewk_Process_Model. ditto. > Source/WebKit2/UIProcess/API/efl/ewk_context.h:396 > + * @param context context object to query. ditto. > Source/WebKit2/UIProcess/API/efl/ewk_context.h:398 > + * @return the process model for the @a context. ditto.

(In reply to comment #6) > (From update of attachment 227643 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227643&action=review > > I'm happy now we can select web process model. LGTM except for my trivial comments. Please fix them before landing. > > > Source/WebKit2/UIProcess/API/efl/ewk_context.h:384 > > + * web process. When EWK_PROCESS_MODEL_MULTIPLY_SECONDARY is set a > > Typo: EWK_PROCESS_MODEL_MULTIPLY_SECONDARY -> EWK_PROCESS_MODEL_MULTIPLE_SECONDARY. > > I wonder whether current our process model only supports network process. Won't we support database process ? Currently it is only implemented for Mac platform, we need to add missing code and of course enable DATABASE_PROCESS flag.

Committed r166228: <http://trac.webkit.org/changeset/166228>